Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process OCR files by file id #225

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Process OCR files by file id #225

merged 1 commit into from
Aug 27, 2023

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Aug 27, 2023

Closing #112

Testplan

  • Ensure that OCR processing for PDF and JPG files still works as before
  • Create manual testcase where we upload a matching document but before triggering cron.php we rename the file. OCR process should still work afterwards.

Artifact

Install artifact for NC28: https://github.com/R0Wi-DEV/workflow_ocr/suites/15532932389/artifacts/886555625

@R0Wi R0Wi requested a review from bahnwaerter August 27, 2023 13:37
@R0Wi R0Wi linked an issue Aug 27, 2023 that may be closed by this pull request
Closing #112

Signed-off-by: Robin Windey <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @R0Wi for your changes. As usual, everything looks fine to me. Now, the OCR workflow should create more detailed exception messages including the filename of the problematic file during processing.

@R0Wi R0Wi merged commit aa5e73d into master Aug 27, 2023
17 checks passed
R0Wi added a commit that referenced this pull request Aug 27, 2023
Closing #112

Signed-off-by: Robin Windey <[email protected]>
R0Wi added a commit that referenced this pull request Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File not found, after the file was renamed
2 participants