feat: Add invalid value case for log reader#47
Merged
GeckoEidechse merged 3 commits intoR2NorthstarTools:mainfrom Aug 27, 2024
Bobbyperson:invalid-value
Merged
feat: Add invalid value case for log reader#47GeckoEidechse merged 3 commits intoR2NorthstarTools:mainfrom Bobbyperson:invalid-value
GeckoEidechse merged 3 commits intoR2NorthstarTools:mainfrom
Bobbyperson:invalid-value
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9.
Adds a check for
Invalid Valuewhich really should just be a message about failed port forwarding instead but Cloudflare appears to be interfering with it. See R2Northstar/Northstar#685 for more infoAlso some minor nitpicking, changes repeated if statements to elif.--> 1d8b074