Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Action] Make sure CI tests cover all components #284

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

pvannierop
Copy link

Fixes #257

Services no longer need to be defined in install-all.yaml.
@pvannierop pvannierop force-pushed the improve-install-all branch 2 times, most recently from 20bbb98 to d758f96 Compare July 4, 2024 09:01
extraEnvVars:
- name: POSTGRESQL_USERNAME
value: postgres
- name: POSTGRES_USER
value: postgres
- name: POSTGRES_MULTIPLE_DATABASES
value: grafana,kratos,data-dashboard
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the radar-grafana and kratos need a time series database?

@pvannierop pvannierop requested a review from keyvaann July 4, 2024 14:19
@@ -0,0 +1,57 @@
atomicInstall: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when #282 is merged we can delete most of the contents of this file

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop merged commit aeae40f into dev Jul 10, 2024
6 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the improve-install-all branch July 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants