Use one secret for TLS certificates

[keyvaann]

This was changed a year ago in this commit
fb46962
But it turns out that now we have get rate limited by Let's Encrypt when requesting for a separate certificate for each application. This PR fixed this.

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

• Is the PR adding a new container? Please reviewer, add it to the models (internal process)
• Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

[pvannierop]

I think the following tls secrets also need to be updated:

• data dashboard backend
• prometheus-alertmanager
• prometheus-grafana
• prometheus-prometheus

We set new secret names for services on a different sub-domain in helmfile layer. So, we can use the same default secret name in the helm charts.

[keyvaann]

Apparently this shouldn't be done. From:

Generate multiple certificates with multiple ingresses
If you need to generate certificates from multiple ingresses make sure it has the issuer annotation. Besides the annotation, it is necessary that each ingress possess a unique tls.secretName

https://cert-manager.io/docs/usage/ingress/#generate-multiple-certificates-with-multiple-ingresses

[pvannierop]

@keyvaann My point is that this is not the concern of the helm chart. The helmfile layer knows about the final domain a service runs on and therefore is also responsible for accommodating the requirement in the cert-manager docs i.e. make sure that when it runs on a domain that requires a different tls secret a new secrete name is set in accordance. I will approve; at least we have had this discussion and indeed it will not matter much for running the platform.