Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of Fitbit API url #293

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

pvannierop
Copy link
Collaborator

Problem

During e2e testing of the Fitbit connector we cannot mock the Fitbit API since the URL is hardcoded.

Solution

This PR will update the chart to make the Fitbit URL configurable.

@pvannierop pvannierop self-assigned this Oct 29, 2024
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit c996c2b into main Oct 29, 2024
5 checks passed
@keyvaann keyvaann deleted the feature/configure-fitbit-api-url branch October 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants