Skip to content

WIP:Upgraded some libraries - specifically matchms #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2025
Merged

WIP:Upgraded some libraries - specifically matchms #157

merged 4 commits into from
May 6, 2025

Conversation

acquayefrank
Copy link
Contributor

Describe your changes

Upgraded matchms library and a few other libraries

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests to see if it is a core feature.

Known Issues

  • IDSM tests fail; I am assuming this is because the syntax may have changed.
  • The keys returned in the new matchms are different from the old; hence, I compared common keys and values.

hechth
hechth reviewed Apr 17, 2025
View reviewed changes
@acquayefrank acquayefrank changed the title Upgraded some libraries - specifically matchms WIP:Upgraded some libraries - specifically matchms Apr 23, 2025
@hechth hechth merged commit e633626 into RECETOX:main May 6, 2025
2 checks passed
@acquayefrank acquayefrank deleted the improvement/upgrading-matchms branch June 9, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hechth hechth hechth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acquayefrank @hechth