Skip to content

feat: build container images with GitHub Actions #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Feb 12, 2025
Merged

feat: build container images with GitHub Actions #132

merged 33 commits into from
Feb 12, 2025

Conversation

r2dedios
Copy link
Collaborator

@r2dedios r2dedios commented Feb 7, 2025

closes #122

This PR includes a first approach for building ClusterIQ images on GH Actions.

  • The workflow has several jobs (one per ClusterIQ component) for parallelized building and error independence.
  • Added building badge to README
  • Updated VERSION file

It took several attempts to finish. Recommended Squash to avoid extremely long commit history

r2dedios added 30 commits February 5, 2025 17:23
@r2dedios
feat: first version container image building gh-actions
5b2cdbe 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: trailling chars
5a0642d 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: typo on workflow
b2689be 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: typo on workflow 2
7a2df18 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: changed runner
97a2d11 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: modified podman instalation for APT
d9e12e3 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
feat: Added go mod tidy and build-args to container image creation
da5a8d3 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: Solving actions errors during API building
4d579e8 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: removed go mod tidy
6fa2496 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: generating gRPC code with protoc in Containerfile-api
4ca4d3f 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: missing 'generated' folder creation
748a419 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: Generating swagger doc on API containerfile
2922280 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: splitted in several layers
87b132d 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: testing swagger doc gen on containerfile
baa538d 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: fixing swagger doc gen
d0278a3 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: fixing swagger doc gen 2
64114db 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: added protoc generation to Agent containerfile
ba6f688 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: Missing generated grpc folder creation
65560ca 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
chore: Separated building on three jobs for independency
aba3b53 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: indentation and debug msgs
4ad9389 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: env vars reference on workflow
6ddb01c 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: fixed output vars reference on gh actions workflow
e63a943 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: Added missing checkout step
41f01c5 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
chore: Logout step common
a5c527d 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
chore: fixed podman login issue and improved tagging steps
f9a559c 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: missing '\' on podman tag step
0f1d853 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
chore: Added conditional version tag building
be89ebb 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
chore: Debug info + final job checking image by commit
bd30c48 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: syntax error
9cae195 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios
fix: Indentation level error
6e180fc 
Signed-off-by: Alejandro Villegas <[email protected]>
@r2dedios r2dedios added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 7, 2025
@r2dedios r2dedios added this to the v0.4 milestone Feb 7, 2025
@r2dedios r2dedios requested a review from vbelouso February 7, 2025 11:22
@r2dedios r2dedios self-assigned this Feb 7, 2025
@r2dedios r2dedios linked an issue Feb 7, 2025 that may be closed by this pull request
Automatic Image Building #122
Closed
@r2dedios r2dedios changed the base branch from main to release-0.4 February 7, 2025 11:22
vbelouso
vbelouso reviewed Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@vbelouso vbelouso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r2dedios
LGTM, but there is one question - why is protoc installed in API?

@r2dedios
Copy link
Collaborator Author

Since the API also works as a gRPC client for sending orders to the Agent, It needs the protobuf definition for building to code.
I included protoc on the API's Containerfile for building the gRPC code during the API compilation too. Additionally, each image can be build from scratch just downloading the code without generating the protoc code apart.

@vbelouso vbelouso changed the title Feature/gh actions 122 feat: implement GitHub actions Feb 12, 2025
@vbelouso vbelouso changed the title feat: implement GitHub actions feat: build container images with GitHub Actions Feb 12, 2025
@vbelouso vbelouso merged commit 4593c5e into release-0.4 Feb 12, 2025
@r2dedios r2dedios deleted the feature/gh-actions-122 branch March 26, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbelouso vbelouso vbelouso left review comments

Assignees

@r2dedios r2dedios

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Automatic Image Building
2 participants
@r2dedios @vbelouso