feat: add java spotless code formatter #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JudeNiroshan
force-pushed
the
code-formatter
branch
from
4046d82
to
a067781
Compare
zvigrinberg
reviewed
Apr 9, 2024
There was a problem hiding this comment.
@JudeNiroshan
Please see my comments.
In addition, i personally find google-java-format more readable and easy to read style for the formatter.
JudeNiroshan
force-pushed
the
code-formatter
branch
2 times, most recently
from
825bf9c
to
becb54f
Compare
Signed-off-by: Jude Niroshan <[email protected]>
Signed-off-by: Jude Niroshan <[email protected]>
zvigrinberg
force-pushed
the
code-formatter
branch
from
becb54f
to
ac49ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce Java spotless code formatter -> https://github.com/diffplug/spotless/tree/main/plugin-maven
Checklist
Additional information
Check pom.xml and license-header files. Everything else is changed because I ran
mvn spotless:applyWhen someone raises a new PR, it will be validated automatically in the build phase of the github actions for PR.