-
Notifications
You must be signed in to change notification settings - Fork 2.1k
makefiles: fix gprof and add gcov #21679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
no no
this is still an issue |
or does it work for you? |
sorry, didn't see that this is still WIP
Honestly I have no clue anymore why the .gcda are not generated. The program exits normally when checking |
int getpid(void)
{
warnx("getpid(): not implemented");
return -1;
} changed to int getpid(void)
{
return thread_getpid();;
} Does not fix it. |
It still fails, but it creates the .gcda files now, but they are empty 😫. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor, general style related things.
#include "map.h" | ||
|
||
#include "embUnit.h" | ||
#include "xtimer.h" | ||
#include "ztimer.h" | ||
|
||
#include "test_utils/interactive_sync.h" | ||
#if IS_USED(MODULE_VFS) | ||
#include "vfs.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "vfs.h" | |
# include "vfs.h" |
VFS_AUTO_MOUNT(native, { .hostpath = FS_NATIVE_DIR }, VFS_DEFAULT_NVM(0), 0); | ||
|
||
#ifndef FS_NATIVE_MOUNT | ||
#define FS_NATIVE_MOUNT VFS_DEFAULT_NVM(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#define FS_NATIVE_MOUNT VFS_DEFAULT_NVM(0) | |
# define FS_NATIVE_MOUNT VFS_DEFAULT_NVM(0) |
Contribution description
Fixing
gprof
targets.Testing procedure
This would fail on master
gprof
for profilinggcov
for coverageStill you will notice that no .gcda are generated. I am trying to find out why.
They should be generated when the program is run (term-gcov) but they are not.
Issues/PRs references