starlight: build on PR & fix CI deploy error #21789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: doc
AnnsAnns
force-pushed
the
docs_build_ci
branch
from
14448bf to
04367d0
Compare
AnnsAnns
force-pushed
the
docs_build_ci
branch
from
bc389c3 to
88d7c35
Compare
Teufelchen1
added
the
CI: ready for build
AnnsAnns
added
the
CI: skip compile test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
With #21787 I accidentally discovered that the "test doc" CI script never ran on PRs, only on pushes. This caused a small error that only occurs on fresh installs (alias the CI) to slip through where the folder structure didn't exist yet.
I changed the workflows to now make a bit more sense. The test build only gets run on PRs (instead of only on pushes to master) and does not get executed when pushing to master (given that deploy docs already counts as a build test)
Testing procedure
Issues/PRs references