-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test all backends together in CI #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cycling CI for #119 |
Parametrisations of the following form @pytest.mark.parametrize(
"G1, G2",
[
*[(graph.lattice(n, n), graph.lattice(n, n)) for n in range(2, 5)],
*[(graph.cycle(n), graph.cycle(n)) for n in range(2, 5)],
],
) have been changed to be parametrised on |
RMeli
commented
Apr 8, 2024
RMeli
commented
Apr 8, 2024
Merged
Jnelen
added a commit
to Jnelen/spyrmsd
that referenced
this pull request
Jun 21, 2024
Fix test so it works with the changes made in PR RMeli#118 Co-authored-by: Rocco Meli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to PR #107
spyrmsd
now supports switching between backends and PR #111 added support for an additional backend. With multiple OSes and Python versions, the CI matrix has become large, and it can be reduced by testing all backends in one go.This PR:
sessionfixture setting the backend, parametrised on all available backendstest/molecules.py
file (also not playing nicely with re-running the tests) in favour of fixturesCloses #110
Checklist