Skip to content

add rosdep ci in humble #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

add rosdep ci in humble #314

merged 3 commits into from
Jun 20, 2025

Conversation

GyuH13
Copy link
Member

@GyuH13 GyuH13 commented Jun 19, 2025

OPEN_MANIPULATOR is maintained with separate branches for Humble and Jazzy

Signed-off-by: Hyungyu Kim <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 23:41
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CI step to improve ROS dependency management in the humble environment by checking and installing dependencies via rosdep.

  • Adds a new job in the GitHub Actions workflow to update rosdep definitions, install system dependencies, and perform a rosdep check.
  • Integrates a clear error reporting mechanism for failed dependency checks.

Comment on lines +50 to +52
rosdep install --from-paths ros_ws/src --ignore-src -y -r --rosdistro ${{ matrix.ros_distribution }}
echo "--- Performing rosdep check for ROS 2 ${{ matrix.ros_distribution }} ---"
if rosdep check --from-paths ros_ws/src --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then
Copy link
Preview

Copilot AI Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider parameterizing the workspace source directory ('ros_ws/src') to improve maintainability if the workspace structure changes.

Suggested change
rosdep install --from-paths ros_ws/src --ignore-src -y -r --rosdistro ${{ matrix.ros_distribution }}
echo "--- Performing rosdep check for ROS 2 ${{ matrix.ros_distribution }} ---"
if rosdep check --from-paths ros_ws/src --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then
rosdep install --from-paths ${{ env.WORKSPACE_SRC_DIR }} --ignore-src -y -r --rosdistro ${{ matrix.ros_distribution }}
echo "--- Performing rosdep check for ROS 2 ${{ matrix.ros_distribution }} ---"
if rosdep check --from-paths ${{ env.WORKSPACE_SRC_DIR }} --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then

Copilot uses AI. Check for mistakes.

if rosdep check --from-paths ros_ws/src --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then
echo "--- rosdep check passed ---"
else
echo "--- rosdep check failed: Missing system dependencies or unresolvable keys. ---"
Copy link
Preview

Copilot AI Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider enhancing the error message with suggestions for troubleshooting or pointers to documentation for resolving missing dependencies.

Suggested change
echo "--- rosdep check failed: Missing system dependencies or unresolvable keys. ---"
echo "--- rosdep check failed: Missing system dependencies or unresolvable keys. ---"
echo "Please check the rosdep logs for more details and verify the keys and dependencies in your workspace."
echo "For troubleshooting, visit: https://docs.ros.org/en/rosdep/latest/"

Copilot uses AI. Check for mistakes.

@robotpilot robotpilot self-assigned this Jun 20, 2025
@robotpilot
Copy link
Member

@yun-goon PING, please check the CI error.

yun-goon added 2 commits June 20, 2025 11:48
Signed-off-by: Wonho Yun <[email protected]>
@robotpilot robotpilot added the enhancement New feature or request label Jun 20, 2025
@github-project-automation github-project-automation bot moved this to 🌱 Todo in Platform Jun 20, 2025
@robotpilot robotpilot moved this from 🌱 Todo to 📝 Pull Request in Platform Jun 20, 2025
@robotpilot robotpilot merged commit c5fd6e9 into humble Jun 20, 2025
1 check passed
@robotpilot robotpilot deleted the feature-rosdep-ci-humble branch June 20, 2025 03:10
@github-project-automation github-project-automation bot moved this from 📝 Pull Request to 🚩Done in Platform Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants