-
Notifications
You must be signed in to change notification settings - Fork 179
add rosdep ci in humble #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hyungyu Kim <[email protected]>
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new CI step to improve ROS dependency management in the humble environment by checking and installing dependencies via rosdep.
- Adds a new job in the GitHub Actions workflow to update rosdep definitions, install system dependencies, and perform a rosdep check.
- Integrates a clear error reporting mechanism for failed dependency checks.
rosdep install --from-paths ros_ws/src --ignore-src -y -r --rosdistro ${{ matrix.ros_distribution }} | ||
echo "--- Performing rosdep check for ROS 2 ${{ matrix.ros_distribution }} ---" | ||
if rosdep check --from-paths ros_ws/src --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider parameterizing the workspace source directory ('ros_ws/src') to improve maintainability if the workspace structure changes.
rosdep install --from-paths ros_ws/src --ignore-src -y -r --rosdistro ${{ matrix.ros_distribution }} | |
echo "--- Performing rosdep check for ROS 2 ${{ matrix.ros_distribution }} ---" | |
if rosdep check --from-paths ros_ws/src --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then | |
rosdep install --from-paths ${{ env.WORKSPACE_SRC_DIR }} --ignore-src -y -r --rosdistro ${{ matrix.ros_distribution }} | |
echo "--- Performing rosdep check for ROS 2 ${{ matrix.ros_distribution }} ---" | |
if rosdep check --from-paths ${{ env.WORKSPACE_SRC_DIR }} --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then |
Copilot uses AI. Check for mistakes.
if rosdep check --from-paths ros_ws/src --ignore-src --rosdistro ${{ matrix.ros_distribution }}; then | ||
echo "--- rosdep check passed ---" | ||
else | ||
echo "--- rosdep check failed: Missing system dependencies or unresolvable keys. ---" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider enhancing the error message with suggestions for troubleshooting or pointers to documentation for resolving missing dependencies.
echo "--- rosdep check failed: Missing system dependencies or unresolvable keys. ---" | |
echo "--- rosdep check failed: Missing system dependencies or unresolvable keys. ---" | |
echo "Please check the rosdep logs for more details and verify the keys and dependencies in your workspace." | |
echo "For troubleshooting, visit: https://docs.ros.org/en/rosdep/latest/" |
Copilot uses AI. Check for mistakes.
@yun-goon PING, please check the CI error. |
Signed-off-by: Wonho Yun <[email protected]>
Signed-off-by: Wonho Yun <[email protected]>
OPEN_MANIPULATOR is maintained with separate branches for Humble and Jazzy