-
Notifications
You must be signed in to change notification settings - Fork 5
Bump 0.5.12 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 0.5.12 #42
Conversation
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Support Incremental Video Encoding in Multi-Task Data Recording Mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Seongoo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily serves as a version increment across the physical_ai
suite of packages to 0.5.12
. The key functional change delivered with this bump is an important fix within the physical_ai_server
that ensures video data is correctly appended in multi-task scenarios, preventing accidental overwrites and improving data integrity.
Highlights
- Version Bump: This pull request updates the version number across all
physical_ai
packages (interfaces, manager, server, and tools) from0.5.11
to0.5.12
. - Video Encoding Improvement: The
physical_ai_server
package has been enhanced to correctly append video encodings in multi-task mode without overwriting existing data. This involves refactoring thelerobot_dataset_wrapper.py
to improve how episode indices are managed and how video paths are generated.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the version from 0.5.11 to 0.5.12 across all packages in the physical AI tools project. The main functional change enables appending video encodings without overwriting existing data in multi-task mode.
- Version bump from 0.5.11 to 0.5.12 across all packages
- Enhanced video encoding functionality to support multi-task mode without data overwriting
- Updated changelogs with the new release information
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
physical_ai_tools/package.xml | Version bump to 0.5.12 |
physical_ai_tools/CHANGELOG.rst | Added changelog entry for 0.5.12 release |
physical_ai_server/setup.py | Version bump to 0.5.12 |
physical_ai_server/physical_ai_server/data_processing/lerobot_dataset_wrapper.py | Enhanced video encoding with episode index tracking and buffer management |
physical_ai_server/physical_ai_server/data_processing/data_manager.py | Removed extra blank line |
physical_ai_server/package.xml | Version bump to 0.5.12 |
physical_ai_server/CHANGELOG.rst | Added changelog entry for 0.5.12 release |
physical_ai_manager/package.json | Version bump to 0.5.12 |
physical_ai_manager/CHANGELOG.rst | Added changelog entry for 0.5.12 release |
physical_ai_interfaces/package.xml | Version bump to 0.5.12 |
physical_ai_interfaces/CHANGELOG.rst | Added changelog entry for 0.5.12 release |
Files not reviewed (1)
- physical_ai_manager/package-lock.json: Language not supported
physical_ai_server/physical_ai_server/data_processing/lerobot_dataset_wrapper.py
Show resolved
Hide resolved
physical_ai_server/physical_ai_server/data_processing/lerobot_dataset_wrapper.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the package versions to 0.5.12 and introduces a fix for multi-task data recording. The core change enables appending video encodings without overwriting existing data. My review focuses on improving the implementation of this new logic in lerobot_dataset_wrapper.py
for better robustness and code clarity.
No description provided.