Skip to content

Update Docker Volume Mounts from /root to Home Directory #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2025

Conversation

Seongoo
Copy link
Member

@Seongoo Seongoo commented Jul 21, 2025

This PR is to update Docker volume mount paths from /root to ~.

Signed-off-by: Seongwoo Kim <[email protected]>
@Seongoo Seongoo requested review from ola31 and DongyunRobotis July 21, 2025 08:51
@Seongoo Seongoo self-assigned this Jul 21, 2025
@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 08:51
@Seongoo Seongoo added the hotfix Software update that is released outside the normal update cycle label Jul 21, 2025
@Seongoo Seongoo added this to Platform Jul 21, 2025
@github-project-automation github-project-automation bot moved this to 🌱 Todo in Platform Jul 21, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Seongoo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes a Docker volume mount configuration by replacing an absolute path with a more portable home directory alias. This change specifically affects how a cache directory is mounted into a Docker container, aiming to improve consistency or compatibility across different environments.

Highlights

  • Docker Volume Mount Update: I've updated the docker/docker-compose.yml file to change the host path for the .cache/huggingface volume mount. It now uses ~/.cache/huggingface instead of /root/.cache/huggingface.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Docker volume mount paths to use the home directory shorthand (~) instead of hardcoded /root paths for better portability and consistency. The change affects the Hugging Face cache mount configuration in the Docker Compose file.

  • Updates Hugging Face cache volume mount from absolute /root path to ~ home directory reference

@Seongoo Seongoo marked this pull request as draft July 21, 2025 08:52
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a Docker volume mount to use the user's home directory instead of a hardcoded /root path. While this is a good improvement for portability, the implementation using ~ is not robust as it relies on shell expansion. I've suggested using the ${HOME} environment variable, which is a more reliable method within Docker Compose.

Seongoo added 2 commits July 21, 2025 17:54
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
@Seongoo Seongoo marked this pull request as ready for review July 21, 2025 08:59
Copy link
Member

@DongyunRobotis DongyunRobotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ola31 ola31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@github-project-automation github-project-automation bot moved this from 🌱 Todo to 📝 Pull Request in Platform Jul 21, 2025
Signed-off-by: Seongwoo Kim <[email protected]>
@Seongoo Seongoo merged commit fb15b35 into main Jul 21, 2025
6 checks passed
@Seongoo Seongoo deleted the feature-volume-mapping-path branch July 21, 2025 09:17
@github-project-automation github-project-automation bot moved this from 📝 Pull Request to 🚩Done in Platform Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Software update that is released outside the normal update cycle
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants