-
Notifications
You must be signed in to change notification settings - Fork 5
Bump 0.5.13 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 0.5.13 #44
Conversation
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Signed-off-by: Seongwoo Kim <[email protected]>
Update Docker Volume Mounts from /root to Home Directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the version from 0.5.12 to 0.5.13 across all packages in the physical_ai_tools project. The main change includes updating Docker volume mount paths from hardcoded /root
to the ${HOME}
environment variable for improved portability and compatibility.
- Updated version numbers across all package configuration files
- Modified Docker volume mount path to use environment variable instead of hardcoded path
- Added changelog entries documenting the changes
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
physical_ai_tools/package.xml | Updated version from 0.5.12 to 0.5.13 |
physical_ai_tools/CHANGELOG.rst | Added changelog entry for version 0.5.13 |
physical_ai_server/setup.py | Updated version from 0.5.12 to 0.5.13 |
physical_ai_server/package.xml | Updated version from 0.5.12 to 0.5.13 |
physical_ai_server/CHANGELOG.rst | Added changelog entry for version 0.5.13 |
physical_ai_manager/package.json | Updated version from 0.5.12 to 0.5.13 |
physical_ai_manager/CHANGELOG.rst | Added changelog entry for version 0.5.13 |
physical_ai_interfaces/package.xml | Updated version from 0.5.12 to 0.5.13 |
physical_ai_interfaces/CHANGELOG.rst | Added changelog entry for version 0.5.13 |
docker/docker-compose.yml | Updated Docker volume mount path to use ${HOME} environment variable |
Files not reviewed (1)
- physical_ai_manager/package-lock.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Seongoo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on a routine version update to 0.5.13
across the physical_ai
project's components. A key functional change included in this release is an improvement to the Docker setup, making volume mounts more flexible and portable by leveraging environment variables.
Highlights
- Version Bump: The project's version has been updated across multiple packages (physical_ai_interfaces, physical_ai_manager, physical_ai_server, physical_ai_tools) from
0.5.12
to0.5.13
. - Docker Configuration Update: The
docker-compose.yml
file has been modified to use the${HOME}
environment variable instead of a hardcoded/root
for the Hugging Face cache volume mount. This change enhances portability and compatibility for Docker environments. - Changelog Updates: Corresponding changelog entries for version
0.5.13
have been added toCHANGELOG.rst
files for all affected packages, withphysical_ai_tools
specifically documenting the Docker path update.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the version to 0.5.13 across all packages. It includes updates to changelogs and package metadata files. The main functional change is an update to the docker-compose.yml
to use a dynamic home directory path for the huggingface cache volume, improving portability. I've provided one suggestion to make this change more robust.
@@ -31,7 +31,7 @@ services: | |||
- /tmp/.X11-unix:/tmp/.X11-unix:rw | |||
- /tmp/.docker.xauth:/tmp/.docker.xauth:rw | |||
- ../:/root/ros2_ws/src/physical_ai_tools/ | |||
- /root/.cache/huggingface:/root/.cache/huggingface | |||
- ${HOME}/.cache/huggingface:/root/.cache/huggingface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While using ${HOME}
is a good step towards making the configuration more portable, it can be brittle. If the HOME
environment variable is not set in the shell where docker-compose
is executed, it will be replaced with an empty string, potentially leading to unexpected volume mounts.
A more robust and standard way to reference the user's home directory in docker-compose.yml
is to use the ~
character. Docker Compose will automatically expand ~
to the current user's home directory.
I suggest using ~
for better portability and to avoid issues with unset environment variables.
- ~/.cache/huggingface:/root/.cache/huggingface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.