-
Notifications
You must be signed in to change notification settings - Fork 113
Rewrite gather to transpose/reshape/broadcast/slice #4550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pfultz2
wants to merge
136
commits into
develop
Choose a base branch
from
codex-gather-rewrite
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Analyze the indices of gather and rewrite it to transpose/reshape/broadcast/slice which can be more easily aliases or fused.
Technical Details
The analyzes the skips in indices and turns it into a shape of strides and an offset that represents that gather operation. The shape is then turned into a series of transpose/reshape/broadcast/slice operators to reproduce that strided access.
Not all sets of strides can be represented using those operators. We need to add an operator like pytorch's
unfoldto handle more of these cases in the future.Since it can take time to analyze the indices, there is a flag to enable it so we can only run it once.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable