Add gfx950 #806
Add gfx950 #806
Conversation
| @@ -11,6 +11,14 @@ | |||
| "expect_failure": True, | |||
| } | |||
| }, | |||
| "gfx950": { | |||
There was a problem hiding this comment.
Can this be tested on the PR itself using a github label to opt-in to this build? Or are you testing with workflow_dispatch somewhere?
There was a problem hiding this comment.
I raised this in internal chat as I am not sure but wanted to send this for early feedback.
There was a problem hiding this comment.
By "tested" I mean test that the build actually succeeds/fails as indicated by expect_failure, not "tested" as in runs tests on a machine with a GPU.
There was a problem hiding this comment.
With "test-runs-on": "", it should only build and not run tests for now but I haven't tested the former yet.
There was a problem hiding this comment.
Yep that's fine. I'm just interested in knowing if the build succeeds (sorry for the overloaded "tested" term)
|
The manually triggered build for gfx950 passed: https://github.com/ROCm/TheRock/actions/runs/15568943706/job/43839877992 Hence, marked this not expected to fail. |
| @@ -13,6 +13,13 @@ | |||
| "pytorch-target": "gfx942", | |||
| } | |||
| }, | |||
| "gfx950": { | |||
There was a problem hiding this comment.
is this gfx95x? or gfx950?
There was a problem hiding this comment.
i can add a label, so folks can add that label and run that target for PRs
No description provided.