Iterate on "installing from tarballs" documentation. #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geomin12
reviewed
Jun 11, 2025
geomin12
reviewed
Jun 11, 2025
|
|
||
| ### Installing tarballs using `install_rocm_from_artifacts.py` | ||
|
|
||
| <!-- TODO: move this above the manual `tar -xf` commands? --> |
There was a problem hiding this comment.
i agree with this, i feel like installing via CI tarballs will be least common way to install? while the python script and wget release will be more common
So best to have:
- Install from release tarballs
- Install tarbals with install_rocm_from_artifacts
- manual CI tarball install
There was a problem hiding this comment.
Yep. I'm hesitant to move it up right now though. One thing I noticed on Windows while refactoring in #772 is that the install script has some baked in concept of "base artifacts" that it always fetches, and that list is maintained manually and may not match what is actually needed. For a full install of the ROCm SDK that supports all uses, the manual install is a safer bet right now.
geomin12
reviewed
Jun 11, 2025
geomin12
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not touching the
install_rocm_from_artifacts.pysection yet... that's probably going to be most flexible and convenient but it needs some quality of life changes to the script that I'll want us to make together with docs changes.