Skip to content

Changing sgpr limits #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Changing sgpr limits #2184

wants to merge 1 commit into from
+28 −16

Conversation

mahmoodw
Copy link
Contributor

@mahmoodw mahmoodw commented Jun 4, 2025

In regards to LWPTENSILE-1696

This includes 2 changes:

  • Unrestricted the temp sgprs needed for gsu from being contiguous, avoiding overflow for certain kernels
  • Account for additional temp sgprs that will be required for code gen, up to physical limits

@mahmoodw mahmoodw requested a review from AlexBrownAMD June 4, 2025 22:38
@msujon-AMD msujon-AMD added the gfx950 run CI on gfx950 label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKyang KKyang KKyang approved these changes

@AlexBrownAMD AlexBrownAMD AlexBrownAMD approved these changes

@jichangjichang jichangjichang Awaiting requested review from jichangjichang jichangjichang is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

@aazz44ss aazz44ss Awaiting requested review from aazz44ss aazz44ss is a code owner

Assignees
No one assigned
Labels
gfx950 run CI on gfx950
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahmoodw @KKyang @AlexBrownAMD @msujon-AMD