Adapt ifdefs to generic architectures #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuron
requested review from
ntrost57,
YvanMokwinski,
jsandham and
kliegeois
as code owners
ntrost57
approved these changes
May 26, 2025
jsandham
approved these changes
May 29, 2025
kliegeois
approved these changes
Jun 5, 2025
|
Do we need anyone else to review? Who can push the merge button? |
Ill double check with the team in our meeting tomorrow and if good ill merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about building with e.g.
GPU_TARGETS="gfx12-generic"(see https://rocm.docs.amd.com/projects/llvm-project/en/develop/conceptual/code-portability.html#generic-code-objects) to reduce compile time and binary size while still being able to run on all architectures relevant to me. This led me to a few#ifdefs that explicitly checked for specific architecture, which this pull request adapts to also support generic architectures.I've opened a similar pull request for rocBLAS at ROCm/rocBLAS#1624.