[PC Sampling]: quick fix for how to invoke rocprof #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocprofiler-compute Pull Request
Related Issue
What type of PR is this? (check all that apply)
Technical Details
The technical evaluation is: the profiling target app cmd string(in args.remaining) should be converted to list before calling rocprof. We have some good practice for other places in the code,
rocprofiler-compute/src/rocprof_compute_profile/profiler_rocprofiler_sdk.py
Line 43 in c7b5a0f
Discussed with @vedithal-amd, we could have better unified solution: apply a transformation function in argparser once(Commented in the code). Because of the time limitation, will do it later after next week.
Have you added or updated tests to validate functionality?
Added / Updated documentation?
Have you updated CHANGELOG?