Skip to content

[PC Sampling]: quick fix for how to invoke rocprof #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

feizheng10
Copy link
Contributor

rocprofiler-compute Pull Request

Related Issue

  • Closes # SWDEV-541054

What type of PR is this? (check all that apply)

  • Bug Fix
  • Cherry Pick
  • Continuous Integration
  • Documentation Update
  • Feature
  • Optimization
  • Refactor
  • Other (please specify)

Technical Details

The technical evaluation is: the profiling target app cmd string(in args.remaining) should be converted to list before calling rocprof. We have some good practice for other places in the code,

app_cmd = shlex.split(self.get_args().remaining)
. We apply similar solution to this case as a quick fix.
Discussed with @vedithal-amd, we could have better unified solution: apply a transformation function in argparser once(Commented in the code). Because of the time limitation, will do it later after next week.

Have you added or updated tests to validate functionality?

  • Yes
  • No - does not apply to this PR

Added / Updated documentation?

  • Yes
  • No - does not apply to this PR

Have you updated CHANGELOG?

  • Yes
  • No - does not apply to this PR

Copy link
Contributor

@vedithal-amd vedithal-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feizheng10 feizheng10 merged commit 3a40e4b into ROCm:develop Jul 31, 2025
10 of 18 checks passed
@feizheng10 feizheng10 deleted the fix_pc_sampling_invocation branch July 31, 2025 14:17
@feizheng10 feizheng10 mentioned this pull request Jul 31, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants