Fix MI100 counter names #848
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not use custom definition for MI100 counters since rocprofiler-sdk supports MI100 counters
vedithal-amd
requested review from
coleramos425,
feizheng10,
xuchen-amd,
cfallows-amd,
ywang103-amd and
jamessiddeley-amd
as code owners
xuchen-amd
reviewed
Aug 1, 2025
| @@ -274,13 +274,13 @@ Panel Config: | |||
| pop: ((100 * AVG((((TCC_EA_WRREQ_64B_sum * 64) + ((TCC_EA_WRREQ_sum - TCC_EA_WRREQ_64B_sum) | |||
| * 32)) / (End_Timestamp - Start_Timestamp)))) / $hbmBandwidth) | |||
| L2-Fabric Read Latency: | |||
| value: AVG(((TCC_EA_RDREQ_LEVEL_sum / TCC_EA_RDREQ_sum) if (TCC_EA_RDREQ_sum | |||
| value: AVG(((TCC_EA0_RDREQ_LEVEL_sum / TCC_EA0_RDREQ_sum) if (TCC_EA0_RDREQ_sum | |||
There was a problem hiding this comment.
TCC_EA0_RDREQ_sum doesn't have gfx908 in: https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal/blob/3a7ff6c9c86d8490f8dd1e057150ca2cf94a8445/source/share/rocprofiler-sdk/counter_defs.yaml#L6649
There was a problem hiding this comment.
same for
TCC_EA0_WRREQ_sum
TCC_EA0_RDREQ_sum
TCC_EA0_WRREQ
TCC_EA0_RDREQ
There was a problem hiding this comment.
It does, please check latest staging branch :) https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal/blob/amd-staging/source/share/rocprofiler-sdk/counter_defs.yaml
feizheng10
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocprofiler-compute Pull Request
Related Issue
What type of PR is this? (check all that apply)
Technical Details
Do not use custom definition for MI100 counters since rocprofiler-sdk supports MI100 counters in https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal/pull/501
Fix MI100 counter names per rocprofiler-sdk definition
Fix metric formulas due to counter name change
Have you added or updated tests to validate functionality?
Added / Updated documentation?
Have you updated CHANGELOG?
Checklist to follow before merge