Skip to content

Update Unit of Bandwidth metrics to Gbps #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update Unit of Bandwidth metrics to Gbps #854

wants to merge 2 commits into from

Conversation

vedithal-amd
Copy link
Contributor

@vedithal-amd vedithal-amd commented Aug 1, 2025 •
edited
Loading

rocprofiler-compute Pull Request

Related Issue

  • Closes #

What type of PR is this? (check all that apply)

  • Bug Fix
  • Cherry Pick
  • Continuous Integration
  • Documentation Update
  • Feature
  • Optimization
  • Refactor
  • Other (please specify)

Technical Details

  • Update Unit of the following Bandwidth related metrics to Gbps instead of Bytes per Normalization Unit

    • Theoretical Bandwidth (section 1202)
    • L1I-L2 Bandwidth (section 1303)
    • sL1D-L2 BW (section 1403)
    • Cache BW (section 1603)
    • L1-L2 BW (section 1603)
    • Read BW (section 1702)
    • Write and Atomic BW (section 1702)
    • Bandwidth (section 1703)
    • Atomic/Read/Write Bandwidth (section 1703)
    • Atomic/Read/Write Bandwidth - (HBM/PCIe/Infinity Fabric) (section 1706)

  • Add Utilization to metric name for the following Bandwidth related metrics whose Unit is Percent

    • Theoretical Bandwidth Utilization (section 1201)
    • L1I-L2 Bandwidth Utilization (section 1301)
    • Bandwidth Utilization (section 1301)
    • Bandwidth Utilization (section 1401)
    • sL1D-L2 BW Utilization (section 1401)
    • Bandwidth Utilization (section 1601)

Have you added or updated tests to validate functionality?

  • Yes
  • No - does not apply to this PR

Added / Updated documentation?

  • Yes
  • No - does not apply to this PR

Have you updated CHANGELOG?

  • Yes
  • No - does not apply to this PR

@vedithal-amd vedithal-amd mentioned this pull request Aug 1, 2025
Merged
15 tasks
@vedithal-amd vedithal-amd force-pushed the update-bandwidths-unit branch from 98e15b9 to 86d6c24 Compare August 1, 2025 19:40
@vedithal-amd
Update Unit of Bandwidth metrics to Gbps
a4bfccc 
* Add Utilization to metric name for Bandwidth related metrics whose Unit
  is Percent

* Update Unit of Bandwidth metrics to Gbps
    * Update metric Formula to use total duration as denominator instead of normalization unit.
    * Update metric Description
    * Update metric Unit

* Update CHANGELOG
@vedithal-amd vedithal-amd force-pushed the update-bandwidths-unit branch from 86d6c24 to a4bfccc Compare August 1, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prbasyal-amd prbasyal-amd Awaiting requested review from prbasyal-amd prbasyal-amd is a code owner

@coleramos425 coleramos425 Awaiting requested review from coleramos425 coleramos425 is a code owner

@feizheng10 feizheng10 Awaiting requested review from feizheng10 feizheng10 is a code owner

@xuchen-amd xuchen-amd Awaiting requested review from xuchen-amd xuchen-amd is a code owner

@cfallows-amd cfallows-amd Awaiting requested review from cfallows-amd cfallows-amd is a code owner

@ywang103-amd ywang103-amd Awaiting requested review from ywang103-amd ywang103-amd is a code owner

@jamessiddeley-amd jamessiddeley-amd Awaiting requested review from jamessiddeley-amd jamessiddeley-amd is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vedithal-amd