Update Unit of Bandwidth metrics to Gbps#854
Closed
vedithal-amd wants to merge 2 commits intoROCm:developfrom
Closed
Update Unit of Bandwidth metrics to Gbps#854vedithal-amd wants to merge 2 commits intoROCm:developfrom
Unit of Bandwidth metrics to Gbps#854vedithal-amd wants to merge 2 commits intoROCm:developfrom
Conversation
vedithal-amd
requested review from
a team,
cfallows-amd,
coleramos425,
feizheng10,
jamessiddeley-amd,
prbasyal-amd,
xuchen-amd and
ywang103-amd
as code owners
15 tasks
vedithal-amd
force-pushed
the
update-bandwidths-unit
branch
2 times, most recently
from
86d6c24 to
a4bfccc
Compare
feizheng10
approved these changes
Aug 5, 2025
Contributor
feizheng10
left a comment
feizheng10
left a comment
There was a problem hiding this comment.
LGTM.
The only thing I'd like to add somewhere(maybe in the doc): for whoever doing BW pe_wave, please apply the normalization with your own yaml config.
* Add Utilization to metric name for Bandwidth related metrics whose Unit
is Percent
* Update Unit of Bandwidth metrics to Gbps
* Update metric Formula to use total duration as denominator instead of normalization unit.
* Update metric Description
* Update metric Unit
* Update CHANGELOG
vedithal-amd
force-pushed
the
update-bandwidths-unit
branch
from
2e8ac6c to
47d9746
Compare
15 tasks
Contributor
|
Imported to ROCm/rocm-systems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocprofiler-compute Pull Request
Related Issue
What type of PR is this? (check all that apply)
Technical Details
Update
Unitof the followingBandwidthrelated metrics toGbpsinstead ofBytes per Normalization UnitAdd
Utilizationto metric name for the followingBandwidthrelated metrics whoseUnitisPercentHave you added or updated tests to validate functionality?
Added / Updated documentation?
Have you updated CHANGELOG?