Skip to content

Unify OMP Target Offload Events into a Single Perfetto #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeniferC99 merged 4 commits into from
Jun 11, 2025
Merged

Unify OMP Target Offload Events into a Single Perfetto #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ed9d2b
SWDEV-507117: Unify OMP Target Offload Events into a Single Perfetto …
habajpai-amd Jun 6, 2025
4e0067d
Update CHANGELOG
dgaliffiAMD Jun 6, 2025
368049c
Update CHANGELOG.md
prbasyal-amd Jun 11, 2025
add8706
Update CHANGELOG.md
prbasyal-amd Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ Full documentation for ROCm Systems Profiler is available at [https://rocm.docs.

## ROCm Systems Profiler 1.0.2 for ROCm 6.4.2

### Optimized

- Improved readability of the OpenMP target offload traces by showing on a single Perfetto track.

### Resolved issues

- Fixed the file path to the script that merges Perfetto files from multi-process MPI runs. The script has also been renamed from "merge-multiprocess-output.sh" to "rocprof-sys-merge-output.sh".
Expand Down
5 changes: 1 addition & 4 deletions source/lib/rocprof-sys/library/ompt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,7 @@ struct ompt : comp::base<ompt, void>

auto _track = tracing::get_perfetto_track(
category::ompt{},
[](uint64_t _targ_id_v) {
return ::timemory::join::join("", "OMP Target ", _targ_id_v);
},
targ_id);
[](auto) -> std::string { return "OpenMP Target Offloads"; }, 0);

category_region<category::ompt>::start<tim::quirk::perfetto>(
name, _track, beg_time, ::perfetto::Flow::ProcessScoped(id),
Expand Down
Loading