Skip to content

Update from version 1.0.0 to 1.0.1 in environment configurations docs #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: amd-staging
Choose a base branch
from

Conversation

alexrosen45
Copy link

rocprofiler-systems version in the "Configuring the environment" section of docs (here) should be 1.0.1 now instead of 1.0.0

@alexrosen45 alexrosen45 requested a review from a team as a code owner June 6, 2025 19:39
@dgaliffiAMD
Copy link
Collaborator

Thank you. Though, I'd say we use 1.1.0, since that is the version in the staging branch.
Alternatively, @ROCm/rocm-documentation, do our doc scripts allow us to use a macro that we can derive from VERSION?

1 similar comment
@dgaliffiAMD
Copy link
Collaborator

Thank you. Though, I'd say we use 1.1.0, since that is the version in the staging branch.
Alternatively, @ROCm/rocm-documentation, do our doc scripts allow us to use a macro that we can derive from VERSION?

@alexrosen45
Copy link
Author

Updated to align with docs from other ROCm components (see)

Comment on lines +43 to +44
module use /opt/rocprofiler-systems/share/modulefiles
module load rocprofiler-systems
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code block is no longer showing what the paragraph above is describing: an example of how "load" and "unload" are used.

We can break it up, if you think that this is clearer. Something like this:

Here is an example of loading and unloading the default version:

module load rocprofiler-systems
module unload rocprofiler-systems

And here is an example of loading a specific version, in this case v1.0.0

module load rocprofiler-systems/1.0.0
module unload rocprofiler-systems/1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants