-
Notifications
You must be signed in to change notification settings - Fork 17
add pull_request_template.md #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pull_request_template.md #237
Conversation
Co-authored-by: David Galiffi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are there any concerns from @ROCm/rocm-documentation, @prbasyal-amd? |
Co-authored-by: David Galiffi <[email protected]>
Will need approval from someone in @ROCm/rocm-documentation before being able to merge. |
I noticed that the PR template I added to compute was not showing up when creating a new PR. Having looked into this, it seems like we need to add query parameters to create a pull request if using the PULL_REQUEST_TEMPLATE subdirectory, which is mostly used for cases where you have multiple templates you want to use. Since we're just using the one, I moved the |
Needs approval from @ROCm/rocm-documentation before being able to merge |
A pull request template was recently added to compute (ROCm/rocprofiler-compute#729), so this will add a similar pull request template to the systems repo.
I have copied the template below, which will now be used when creating a new PR in this repo.
rocprofiler-systems Pull Request
Related Issue
What type of PR is this? (check all that apply)
Technical Details
Have you added or updated tests to validate functionality?
Added / Updated documentation?
Have you updated CHANGELOG?