Skip to content

add pull_request_template.md #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jbonnell-amd
Copy link
Collaborator

@jbonnell-amd jbonnell-amd commented Jun 9, 2025

A pull request template was recently added to compute (ROCm/rocprofiler-compute#729), so this will add a similar pull request template to the systems repo.

I have copied the template below, which will now be used when creating a new PR in this repo.

rocprofiler-systems Pull Request

Related Issue

  • Closes #

What type of PR is this? (check all that apply)

  • Bug Fix
  • Cherry Pick
  • Continuous Integration
  • Documentation Update
  • Feature
  • Optimization
  • Refactor
  • Other (please specify)

Technical Details

Have you added or updated tests to validate functionality?

  • Yes
  • No - does not apply to this PR

Added / Updated documentation?

  • Yes
  • No - does not apply to this PR

Have you updated CHANGELOG?

  • Yes
  • No - does not apply to this PR

@jbonnell-amd jbonnell-amd requested a review from a team as a code owner June 9, 2025 15:21
@sputhala-amd sputhala-amd requested a review from dgaliffiAMD June 9, 2025 15:48
sputhala-amd
sputhala-amd previously approved these changes Jun 10, 2025
Copy link
Collaborator

@sputhala-amd sputhala-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgaliffiAMD dgaliffiAMD requested a review from prbasyal-amd June 10, 2025 18:10
@dgaliffiAMD
Copy link
Collaborator

Are there any concerns from @ROCm/rocm-documentation, @prbasyal-amd?

dgaliffiAMD
dgaliffiAMD previously approved these changes Jun 11, 2025
@jbonnell-amd
Copy link
Collaborator Author

Will need approval from someone in @ROCm/rocm-documentation before being able to merge.

@jbonnell-amd
Copy link
Collaborator Author

I noticed that the PR template I added to compute was not showing up when creating a new PR. Having looked into this, it seems like we need to add query parameters to create a pull request if using the PULL_REQUEST_TEMPLATE subdirectory, which is mostly used for cases where you have multiple templates you want to use.

Since we're just using the one, I moved the pull_request_template.md file to the base .github directory since it should detect this without needing query parameters.

@jbonnell-amd
Copy link
Collaborator Author

Needs approval from @ROCm/rocm-documentation before being able to merge

@jbonnell-amd jbonnell-amd merged commit da32604 into ROCm:amd-staging Jun 12, 2025
42 checks passed
@jbonnell-amd jbonnell-amd deleted the create-pull-request-template branch June 12, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants