-
Notifications
You must be signed in to change notification settings - Fork 18
Added stream_id to Perfetto annotations #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added stream_id to Perfetto annotations #274
Conversation
I see the stream_id for the
|
I just merged with |
Based on the `ROCPROFSYS_ROCM_GROUP_BY_QUEUE` setting, group these traces accordingly in the Perfetto trace. Signed-off-by: David Galiffi <[email protected]>
…ption. If it is not supported, we cannot group by HIP stream and must default to grouping by HSA queue
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
… called only once
The HIP_STREAM callback was new in ROCPROFILER v0.7.0 Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
error: C++ designated initializers only available with ‘-std=c++20’ or ‘-std=gnu++20’ [-Werror=c++20-extensions] Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
`memory_copy` and `kernel_dispatch` events should use the same category otherwise duplicate perfetto tracks are created.
406f2e2
to
54fb2f0
Compare
Rebasing with |
Signed-off-by: David Galiffi <[email protected]>
rocprofiler-systems Pull Request
Related Issue
What type of PR is this? (check all that apply)
Technical Details
memory_copy
andkernel_dispatch
events with their HIPstream_id
and addstream_id
as an annotation in Perfetto.memory_copy
andkernel_dispatch
events in Perfetto output by theirstream_id
.ROCPROFSYS_ROCM_GROUP_BY_QUEUE
, to group by HSA queue instead.Have you added or updated tests to validate functionality?
Added / Updated documentation?
Have you updated CHANGELOG?