Added stream_id to Perfetto annotations

[ajanicijamd]

rocprofiler-systems Pull Request

Related Issue

• Closes #

What type of PR is this? (check all that apply)

• Bug Fix
• Cherry Pick
• Continuous Integration
• Documentation Update
• Feature
• Optimization
• Refactor
• Other (please specify)

Technical Details

Have you added or updated tests to validate functionality?

• Yes
• No - does not apply to this PR

Added / Updated documentation?

• Yes
• No - does not apply to this PR

Have you updated CHANGELOG?

• Yes
• No - does not apply to this PR

[dgaliffiAMD]

I see the stream_id for the rocm_kernel_dispatch events. That looks good. I used our transpose example to validate.

• stream_id seems to be missing from the rocm_memory_copy events. I'm not sure why it's missing there yet.
• In tool_tracing_buffered, we'll still have to update the track names for the two categories to correspond to the HIP Streams, so they are grouped together. For example, "HIP Activity [0] Stream 1" to group together rocm_memory_copy and rocm_kernel_dispatch events for stream_id 1. I have some sample code on my local branch to show you what I mean.
• We still need a new configuration option to allow the user to toggle between the two grouping styles.
• Lastly, we'll need to add some compile-time and runtime-time guards to preserve backwards compatibility. The HIP_STREAM callback was only introduced in ROCPROFILER_VERSIONS >= 700.

[dgaliffiAMD]

I just merged with amd-staging to resolve a conflict there.
You can also take a look at https://github.com/dgaliffiAMD/rocprofiler-systems/tree/group-by-stream. I added some code to support a ROCPROFSYS_ROCM_GROUP_BY_QUEUE, so we can toggle between grouping by HSA queue or HIP stream. We still need add some documentation and testing around this, though

[dgaliffiAMD]

rocprofiler_configure_callback_tracing_service will return an error in this case if both "kernel-dispatch" and "memory-copy" are enabled.

Instead, you can change the logic to something like this:

if ROCPROFILER_BUFFER_TRACING_KERNEL_DISPATCH
   setup specific to kernel-dispatch

if ROCPROFILER_BUFFER_TRACING_MEMORY_COPY 
   setup specific to memory-copy

if ROCPROFILER_BUFFER_TRACING_MEMORY_COPY or ROCPROFILER_BUFFER_TRACING_KERNEL_DISPATCH
   rocprofiler_configure_callback_tracing_service(ROCPROFILER_CALLBACK_TRACING_HIP_STREAM)