Added stream_id to Perfetto annotations #274

ajanicijamd · 2025-06-27T20:31:00Z

rocprofiler-systems Pull Request

Related Issue

Closes SWDEV-538070

What type of PR is this? (check all that apply)

Technical Details

Corelate memory_copy and kernel_dispatch events with their HIP stream_id and add stream_id as an annotation in Perfetto.
By default, group memory_copy and kernel_dispatch events in Perfetto output by their stream_id.
Add option, with the configuration setting ROCPROFSYS_ROCM_GROUP_BY_QUEUE, to group by HSA queue instead.

Have you added or updated tests to validate functionality?

Yes
No - does not apply to this PR

Added / Updated documentation?

Yes
No - does not apply to this PR

Have you updated CHANGELOG?

Yes
No - does not apply to this PR

source/lib/rocprof-sys/library/rocprofiler-sdk.cpp

dgaliffiAMD · 2025-07-09T04:50:38Z

I see the stream_id for the rocm_kernel_dispatch events. That looks good. I used our transpose example to validate.

stream_id seems to be missing from the rocm_memory_copy events. I'm not sure why it's missing there yet.
In tool_tracing_buffered, we'll still have to update the track names for the two categories to correspond to the HIP Streams, so they are grouped together. For example, "HIP Activity [0] Stream 1" to group together rocm_memory_copy and rocm_kernel_dispatch events for stream_id 1. I have some sample code on my local branch to show you what I mean.
We still need a new configuration option to allow the user to toggle between the two grouping styles.
Lastly, we'll need to add some compile-time and runtime-time guards to preserve backwards compatibility. The HIP_STREAM callback was only introduced in ROCPROFILER_VERSIONS >= 700.

dgaliffiAMD · 2025-07-16T22:18:54Z

I just merged with amd-staging to resolve a conflict there.
You can also take a look at https://github.com/dgaliffiAMD/rocprofiler-systems/tree/group-by-stream. I added some code to support a ROCPROFSYS_ROCM_GROUP_BY_QUEUE, so we can toggle between grouping by HSA queue or HIP stream. We still need add some documentation and testing around this, though

source/lib/rocprof-sys/library/rocprofiler-sdk.cpp

external/timemory

docs/reference/development-guide.rst

Based on the `ROCPROFSYS_ROCM_GROUP_BY_QUEUE` setting, group these traces accordingly in the Perfetto trace. Signed-off-by: David Galiffi <[email protected]>

…ption. If it is not supported, we cannot group by HIP stream and must default to grouping by HSA queue

Signed-off-by: David Galiffi <[email protected]>

… called only once

The HIP_STREAM callback was new in ROCPROFILER v0.7.0 Signed-off-by: David Galiffi <[email protected]>

Signed-off-by: David Galiffi <[email protected]>

error: C++ designated initializers only available with ‘-std=c++20’ or ‘-std=gnu++20’ [-Werror=c++20-extensions] Signed-off-by: David Galiffi <[email protected]>

Signed-off-by: David Galiffi <[email protected]>

`memory_copy` and `kernel_dispatch` events should use the same category otherwise duplicate perfetto tracks are created.

dgaliffiAMD · 2025-07-22T23:52:49Z

Rebasing with amd-staging

Signed-off-by: David Galiffi <[email protected]>

ajanicijamd marked this pull request as ready for review June 27, 2025 21:01

ajanicijamd requested review from jrmadsen and a team as code owners June 27, 2025 21:01

dgaliffiAMD reviewed Jul 8, 2025

View reviewed changes

source/lib/rocprof-sys/library/rocprofiler-sdk.cpp Outdated Show resolved Hide resolved

dgaliffiAMD reviewed Jul 17, 2025

View reviewed changes

source/lib/rocprof-sys/library/rocprofiler-sdk.cpp Outdated Show resolved Hide resolved

dgaliffiAMD reviewed Jul 17, 2025

View reviewed changes

external/timemory Outdated Show resolved Hide resolved

ajanicijamd requested a review from a team as a code owner July 22, 2025 15:57

dgaliffiAMD reviewed Jul 22, 2025

View reviewed changes

docs/reference/development-guide.rst Show resolved Hide resolved

ajanicijamd and others added 20 commits July 22, 2025 19:50

Added stream_id to Perfetto annotations

d8ece83

Fixed formatting

6f2fc6b

Fixed formatting

7253e24

Added check if stream_id is not 0, for the review

676f39a

Fixed a callback configuration

f508259

Fixed formatting

5d3286a

Fixed formatting

14cc8ce

Create new configuration setting ROCPROFSYS_ROCM_GROUP_BY_QUEUE

1cc942a

Change grouping of memory copies and kernel dispatches

788e9f7

Based on the `ROCPROFSYS_ROCM_GROUP_BY_QUEUE` setting, group these traces accordingly in the Perfetto trace. Signed-off-by: David Galiffi <[email protected]>

Resolved conflict

c354c94

Fixed formatting

e1ec18c

Check if HIP_STREAM is supported before adding the "GROUP_BY_QUEUE" o…

7960019

…ption. If it is not supported, we cannot group by HIP stream and must default to grouping by HSA queue

Moving lambda definition outside of the loop

819a456

Signed-off-by: David Galiffi <[email protected]>

Fix submodule pointer for timemory

891af3b

Signed-off-by: David Galiffi <[email protected]>

Reorganized code so rocprofiler_configure_callback_tracing_service is…

c9c7c50

… called only once

Fix for back compatibility CIs.

1c1a3ed

The HIP_STREAM callback was new in ROCPROFILER v0.7.0 Signed-off-by: David Galiffi <[email protected]>

Add tests for group-by settings

63845b2

Signed-off-by: David Galiffi <[email protected]>

Documented the new configuration variable ROCPROFSYS_ROCM_GROUP_BY_QUEUE

8596c85

Fix group-by test for non-ROCm builds

94d9cfc

Signed-off-by: David Galiffi <[email protected]>

Fix Ubuntu 24 compiler error

f8fda3d

error: C++ designated initializers only available with ‘-std=c++20’ or ‘-std=gnu++20’ [-Werror=c++20-extensions] Signed-off-by: David Galiffi <[email protected]>

ajanicijamd and others added 11 commits July 22, 2025 19:52

Modified check for ROCm version

8bd8b04

Modified check for ROCm version

955ab3f

Fixed formatting

f90431c

Update CHANGELOG

fcfe3f6

Signed-off-by: David Galiffi <[email protected]>

Update cmake check to use ROCmVersion_FOUND

c737f5b

Signed-off-by: David Galiffi <[email protected]>

Add new category for rocm_hip_stream

fe015f9

Fixed perfetto tracks when grouping by stream.

7cc45da

`memory_copy` and `kernel_dispatch` events should use the same category otherwise duplicate perfetto tracks are created.

Clean up and refactor

b5f8ccd

Update perfetto validation in ctest

c4b40d2

Remove debug logs

8899ddc

Removing perfetto validation test

54fb2f0

dgaliffiAMD force-pushed the ajanicij/hip-streams branch from 406f2e2 to 54fb2f0 Compare July 22, 2025 23:52

Fix backwards compitability compilation

a417140

Signed-off-by: David Galiffi <[email protected]>

dgaliffiAMD approved these changes Jul 23, 2025

View reviewed changes

dgaliffiAMD merged commit 4b4a846 into ROCm:amd-staging Jul 24, 2025
45 of 50 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added stream_id to Perfetto annotations #274

Added stream_id to Perfetto annotations #274

ajanicijamd commented Jun 27, 2025 •

edited by dgaliffiAMD

Loading

Uh oh!

Uh oh!

dgaliffiAMD commented Jul 9, 2025 •

edited

Loading

Uh oh!

dgaliffiAMD commented Jul 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgaliffiAMD commented Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

Added stream_id to Perfetto annotations #274

Added stream_id to Perfetto annotations #274

Conversation

ajanicijamd commented Jun 27, 2025 • edited by dgaliffiAMD Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

rocprofiler-systems Pull Request

Related Issue

What type of PR is this? (check all that apply)

Technical Details

Have you added or updated tests to validate functionality?

Added / Updated documentation?

Have you updated CHANGELOG?

Uh oh!

Uh oh!

dgaliffiAMD commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dgaliffiAMD commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgaliffiAMD commented Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

ajanicijamd commented Jun 27, 2025 •

edited by dgaliffiAMD

Loading

dgaliffiAMD commented Jul 9, 2025 •

edited

Loading

dgaliffiAMD commented Jul 16, 2025 •

edited

Loading