Deny PKG installation without RAP #17828
Open
+164
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think the message only creates more questions than answers. |
Megamouse
reviewed
Dec 6, 2025
|
|
||
| if (std::count(missing_licenses_short.begin(), missing_licenses_short.end(), '\n') < 5) | ||
| { | ||
| missing_licenses_short += std::string_view(filepath).substr(filepath.find_last_of(fs::delim) + 1); |
Contributor
There was a problem hiding this comment.
What's the purpose of casting to stringview here?
Megamouse
reviewed
Dec 6, 2025
Megamouse
reviewed
Dec 6, 2025
Megamouse
reviewed
Dec 6, 2025
| return {}; | ||
| } | ||
|
|
||
| if (npd->license == 1) // Network license. |
Megamouse
reviewed
Dec 6, 2025
| } | ||
|
|
||
| // Check the ELF file class (32 or 64 bit). | ||
| const bool isElf32 = IsSelfElf32(elf_or_self); |
Megamouse
reviewed
Dec 7, 2025
| return m_file; | ||
| } | ||
|
|
||
| const std::string& gep_needed_rap_file_path() const |
Contributor
There was a problem hiding this comment.
Suggested change
| const std::string& gep_needed_rap_file_path() const | |
| const std::string& get_needed_rap_file_path() const |
Megamouse
reviewed
Dec 7, 2025
|
|
||
| for (const auto& reader : readers) | ||
| { | ||
| if (std::string filepath = reader.gep_needed_rap_file_path(); !filepath.empty() && fs::is_file(filepath)) |
Contributor
There was a problem hiding this comment.
shouldn't this be !fs::is_file ?
Contributor
Author
There was a problem hiding this comment.
Yes, this is a debug change that sleeped 👍
Megamouse
reviewed
Dec 7, 2025
| "\nEnsure the .rap license file is placed in the dev_hdd0/home/%s/exdata folder with a lowercase file extension." | ||
| "\nIf you need assistance on dumping the license file from your PS3, read our quickstart guide: https://rpcs3.net/quickstart", missing_licenses, Emu.GetUsr()); | ||
|
|
||
| QString error = tr("Failed to locate the game license file(s):\n\n%1\nEnsure the .rap license file(s) are placed in the dev_hdd0 folder with a lowercase file extension.").arg(QString::fromStdString(missing_licenses_short)); |
Contributor
There was a problem hiding this comment.
Suggested change
| QString error = tr("Failed to locate the game license file(s):\n\n%1\nEnsure the .rap license file(s) are placed in the dev_hdd0 folder with a lowercase file extension.").arg(QString::fromStdString(missing_licenses_short)); | |
| const QString error = tr("Failed to locate the game license file(s):\n\n%1\nEnsure the .rap license file(s) are placed in the dev_hdd0 folder with a lowercase file extension.").arg(QString::fromStdString(missing_licenses_short)); |
Megamouse
reviewed
Dec 7, 2025
Comment on lines
+54
to
+55
| QString last_pkg_path_postponed_due_to_missing_rap; | ||
| QString last_rap_file_needed_for_pkg; |
Contributor
There was a problem hiding this comment.
What does this do ? too lazy
Suggested change
| QString last_pkg_path_postponed_due_to_missing_rap; | |
| QString last_rap_file_needed_for_pkg; | |
| QString m_last_pkg_path_postponed_due_to_missing_rap; | |
| QString m_last_rap_file_needed_for_pkg; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log error is remained, and if you install multiple PKGs it would only print the missing RAP file path.
Relates to #17805
Edit: Added RAP redemption: if you failed to have RAP while attempting to install PKG, drag-and-droping the needed RAP file would re-attempt the PKG installation like magic. RPCS3 uses advanced AI to read your mind's intentions.