[macOS] Properly handle app bundle versioning (& minor CI fix) #17967
+20
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schm1dtmac
changed the title
Megamouse
added
OS: macOS
Build and CI
schm1dtmac
force-pushed
the
miscfixes
branch
19 times, most recently
from
e37128e to
5667291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranged some stuff in the CI scripts to enable passing through the RPCS3 version to CMake, so it can be set properly in Info.plist.
CFBundleShortVersionString now gets set to and displayed in e.g. Finder, System Information, System Preferences, etc as 0.0.39 as of now (follows Apple's explicit rule for this to be a strict 3-digit version number).
CFBundleVersion is also now set to the current commit count/build number (e.g. 18609 or whatever), as per convention for most Apple apps and from old-but-gold Leopard-era development documentation (although this number isn't shown anywhere in the GUI since RPCS3 uses a Qt about window instead of the OS one, the latter of which would display something like 0.0.39 (18609) as configured above).
Also fixed a small CI issue with release archive naming for arm64.
(Note: if checks freeze and timeout inexplicably it’s a GH issue, actions reliability can be shit at times, unrelated to the PR itself ofc)