handle lcov end line number #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Similar to #104, do you mind adding a test case to |
Cheekie25
force-pushed
the
handle_lcov_end_line_number
branch
2 times, most recently
from
a3cedc0 to
3f372e5
Compare
According to the lcov documentation, `FN` field can contain optional end line number. Right now the code crashes in this case. This commit makes sure it doesn't and it's well parsed. Ref: https://manpages.ubuntu.com/manpages/noble/man1/geninfo.1.html ``` Following is a list of line numbers for each function name found in the source file: FN:<line number of function start>,(<line number of function end>,)?<function name> The 'end' line number is optional, and is generated only if the compiler/toolchain version is recent enough to generate the data (e.g., gcc 9 or newer). ```
Cheekie25
force-pushed
the
handle_lcov_end_line_number
branch
from
3f372e5 to
a9f3f39
Compare
Owner
|
Looks good, thanks for adding the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the lcov documentation,
FNfield can contain optional end line number.Right now the code crashes in this case.
This commit makes sure it doesn't and it's well parsed.
Ref: https://manpages.ubuntu.com/manpages/noble/man1/geninfo.1.html