-
Notifications
You must be signed in to change notification settings - Fork 269
Set the bundle address on the i18n helper for handlebars. #5650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
For the draw backs you missed one big one this functionality means you can no longer change the names of keys or remove or keys from the property bundle file once it's merged One a key goes into the i18n file and it's released is there forever. Which means you will no longer be able to do the reorganization and consolidation you periodically do |
Spoilsport. |
Set the bundle address on the i18n helper for handlebars.
Set the bundle address on the i18n helper for handlebars.
@cwisniew Made a whole new resource bundle for stat-sheets to play with. Problem solvered. |
property.agility = Agility | ||
property.alertness = Alertness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here downwards kind of misses the point of the statsheets, the stat sheet is to display what the user has selected, not arbitrary values. There is a display name for each property which can be used for i18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwisniew Kinda yes, aaaaand kinda no.
Imagine a world where I roleplay with people who have differing primary languages and the GM has just picked some random framework off a forum somewhere.
How gob-smacked would I be if his stat-sheets and character-sheets would be delivered in my native language, even though the stats were actually their standard English in the system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwisniew Kinda yes, aaaaand kinda no. Imagine a world where I roleplay with people who have differing primary languages and the GM has just picked some random framework off a forum somewhere. How gob-smacked would I be if his stat-sheets and character-sheets would be delivered in my native language, even though the stats were actually their standard English in the system?
The way you are doing it is definaltey no not kinda no :)
What you really want to do is have the display name as either a name the user types in, or a key value they can pick from (think similar to the IntelliJ forms designer) in the properties dialog. Then the display name would be populated with either the lookup of the key or the value, and the person writing the statsheet would have to do nothing extra. Maybe also start a discord thread to collect all the other names people want, I am sure there will be plenty:)
Identify the Bug or Feature request
closes #4141
Description of the Change
We already had the functionality, it just wasn't set up correctly.
Added the properties file address to the Handlebars helper and now it flies.
Possible Drawbacks
crazy people
Documentation Notes
Added i18n functionality to Handlebars
This change is