Skip to content

Set the bundle address on the i18n helper for handlebars. #5650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented Jun 27, 2025

Identify the Bug or Feature request

closes #4141

Description of the Change

We already had the functionality, it just wasn't set up correctly.
Added the properties file address to the Handlebars helper and now it flies.

Possible Drawbacks

crazy people

Documentation Notes

Added i18n functionality to Handlebars


This change is Reviewable

@github-actions github-actions bot added the feature Adding functionality that adds value label Jun 27, 2025
@bubblobill bubblobill added performance A performance or quality of life improvement translations add-on support labels Jun 27, 2025
@bubblobill bubblobill self-assigned this Jun 27, 2025
@bubblobill bubblobill requested a review from kwvanderlinde June 27, 2025 17:35
@cwisniew
Copy link
Member

cwisniew commented Jun 28, 2025

For the draw backs you missed one big one

this functionality means you can no longer change the names of keys or remove or keys from the property bundle file once it's merged

One a key goes into the i18n file and it's released is there forever. Which means you will no longer be able to do the reorganization and consolidation you periodically do

@bubblobill
Copy link
Collaborator Author

Spoilsport.

@bubblobill bubblobill marked this pull request as draft June 28, 2025 05:36
Set the bundle address on the i18n helper for handlebars.
Set the bundle address on the i18n helper for handlebars.
@bubblobill bubblobill marked this pull request as ready for review June 28, 2025 07:34
@bubblobill bubblobill requested a review from cwisniew June 28, 2025 07:34
@bubblobill
Copy link
Collaborator Author

@cwisniew Made a whole new resource bundle for stat-sheets to play with. Problem solvered.

Comment on lines +22 to +23
property.agility = Agility
property.alertness = Alertness
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From here downwards kind of misses the point of the statsheets, the stat sheet is to display what the user has selected, not arbitrary values. There is a display name for each property which can be used for i18n

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwisniew Kinda yes, aaaaand kinda no.
Imagine a world where I roleplay with people who have differing primary languages and the GM has just picked some random framework off a forum somewhere.
How gob-smacked would I be if his stat-sheets and character-sheets would be delivered in my native language, even though the stats were actually their standard English in the system?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwisniew Kinda yes, aaaaand kinda no. Imagine a world where I roleplay with people who have differing primary languages and the GM has just picked some random framework off a forum somewhere. How gob-smacked would I be if his stat-sheets and character-sheets would be delivered in my native language, even though the stats were actually their standard English in the system?

The way you are doing it is definaltey no not kinda no :)
What you really want to do is have the display name as either a name the user types in, or a key value they can pick from (think similar to the IntelliJ forms designer) in the properties dialog. Then the display name would be populated with either the lookup of the key or the value, and the person writing the statsheet would have to do nothing extra. Maybe also start a discord thread to collect all the other names people want, I am sure there will be plenty:)

@bubblobill bubblobill marked this pull request as draft July 19, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-on support feature Adding functionality that adds value performance A performance or quality of life improvement translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Localised field labels for stat-sheet handlebars templates
2 participants