Preferences Revamp #5727
Draft
Preferences Revamp #5727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kwvanderlinde @cwisniew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
resolves #4987
Description of the Change
Generates the Preferences dialog rather than using a form.
Based on the preference type, a label and control are generated and added to the preferences presented to the user.
Includes a search box for finding what you want quickly.
Adding a simple user preference to the form requires adding it to an enum of user preferences and including which section(think "tab") and group (e.g. token/map/etc.) it belongs to, and whether or not to use auto-generated controls.
Currently toying with different presentations. Present iteration is a Tree and a JideGroupTable.
Possible Drawbacks
Too much hard-coding still. Will probably replace the enum with a record register. Keeping backwards compatibility currently involves some silliness.
Documentation Notes
Reworked User Preferences
Release Notes
This change is