Merge release-1.18 into develop #5825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ImageUtil#getTokenImage(Token, ImageObserver[])` is redundant and has been removed. Any callers of this method can instead just call `Token#getTokenImageAssetId()` followed by `ImageManager.getImage(MD5Key, ImageObserver[])`. The `TokenRenderer` no longer tries to cache token images per facing, and instead uses the above technique to get the image each time. This cache wasn't really functional since entries could never be ejected or updated. Being static, this also meant it was a memory leak as all the images ever cached would be kept in `TokenRenderer#imageTableMap`.
All `null` results from the image table lookup are now guaranteed to use the fallback to `Token#getImageAssetId()`.
…able-image-shown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few merge conflicts had to be resolve given the divergence between
developandrelease-1.18. Otherwise, a routine release merge.This change is