Enable warnings refactor #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the selected cases, they do not ever use negative values and often are used to index arrays directly. uint32_t is also more in line with other places of LIKWID.
This avoids: - unused function lock_check warning - duplicated code
Technically, the linker can probably dedudplicate those strings, when the header is included multiple times. Though, this avoids the warning of unused variable.
What remains to solve are those unused socket parameters. Why are they there? They are currently not used as part of an interface, which would require this.
ipatix
force-pushed
the
enable-warnings-refactor
branch
from
02ef270 to
40f9256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the code for enabling compiler warnings. Currently, the code needs fixes because otherwise you'd encounter walls of warnings.
While this PR fixes most of the compiler warnings (which are not yet enabled), it does not always fix the underlying issue, which the warning is reminding us about.
Not all warnings are fixed in this PR. Most notably unused variable warnings in perfmon.c. That is because too many changes (for now) would be necessary to fix them.