Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Pipe's NBT don't save properly #1679

Open
KorewaLidesu opened this issue Dec 4, 2022 · 4 comments
Open

[Bug] Pipe's NBT don't save properly #1679

KorewaLidesu opened this issue Dec 4, 2022 · 4 comments
Labels
Accepted Will be fixed or implemented Bug
Milestone
LP 0.10.4

Comments

@KorewaLidesu
Copy link
Contributor

KorewaLidesu commented Dec 4, 2022 •
edited
Loading

writetoNBT doesn't fire after pause/leave the world unless you update the tile entity manual or tick() kick in.
How to reproduct:
Join the world, change stuff on pipe then leave immediately
Join again and see result.
Environment: Dev branch, no changed in core.
Video: https://www.youtube.com/watch?v=Q7wQEYYXkEQ
@KorewaLidesu
Copy link
Contributor Author

May related to #995

@KorewaLidesu KorewaLidesu changed the title [Bug] Satellite name don't save properly [Bug] Pipe's NBT don't save properly Dec 4, 2022
@KorewaLidesu KorewaLidesu mentioned this issue Dec 4, 2022
Closed
@KorewaLidesu
Copy link
Contributor Author

I just found out reason why.
Pipe didn't markDirty when close gui cause their NBT don't sync properly.

@KorewaLidesu KorewaLidesu mentioned this issue Jan 3, 2023
Closed
@bziemons
Copy link
Member

bziemons commented Feb 21, 2023 •
edited
Loading

Crafting pipe, provider pipe, supplier pipe and basic logistics pipe should be fixed since now in ffe178d

So let's make a list with TEs missing properties and therefore do not save correctly after modification:

  • PipeBlockRequestTable (technically a pipe)
  • PipeFluidExtractor (no GUI)
  • PipeFluidInsertion (no GUI)
  • PipeFluidSatellite
  • PipeFluidSupplierMk2
  • PipeItemsFirewall
  • PipeItemsFluidSupplier
  • PipeItemsInvSysConnector
  • PipeItemsRequestLogisticsMk2
  • PipeItemsSatelliteLogistics
  • PipeItemsSystemDestinationLogistics
  • PipeItemsSystemEntranceLogistics
  • PipeLogisticsChassis (pointedAdjacent and slotUpgradeManagers)

@bziemons bziemons added Bug Accepted Will be fixed or implemented labels Feb 21, 2023
@bziemons bziemons added this to the LP 0.10.4 milestone Feb 21, 2023
@KorewaLidesu
Copy link
Contributor Author

KorewaLidesu commented Mar 10, 2023 •
edited
Loading

All tick'd is mean it is implemented
And all in here hasn't test properly, so I will as someone to check it first before the PR

  • PipeBlockRequestTable
  • PipeFluidExtractor
  • PipeFluidInsertion
  • PipeFluidSatellite
  • PipeFluidSupplierMk2
  • PipeItemsFirewall
  • PipeItemsFluidSupplier
  • PipeItemsInvSysConnector
  • PipeItemsRequestLogisticsMk2
  • PipeItemsSatelliteLogistics
  • PipeItemsSystemDestinationLogistics
  • PipeItemsSystemEntranceLogistics
  • PipeLogisticsChassis

KorewaLidesu added a commit to JP-HellParadise/LogisticsPipes that referenced this issue Mar 10, 2023
@KorewaLidesu
Implementing Module system for PipeFluidExtractor, PipeFluidInsertion…
6ff8fd8 
…, PipeFluidSatellite, PipeFluidSupplierMk2, PipeItemsFluidSupplier. Change conditions stuff in PipeItemsSatelliteLogistics (Commit for: RS485#1679)
KorewaLidesu added a commit to JP-HellParadise/LogisticsPipes that referenced this issue Mar 10, 2023
@KorewaLidesu
Implementing Module system for PipeBlockRequestTable, add a small con…
91516c3 
…struction on SimpleStackInventory (Commit for: RS485#1679)
@KorewaLidesu KorewaLidesu mentioned this issue Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Will be fixed or implemented Bug
Projects
None yet
Milestone
LP 0.10.4
Development

Successfully merging a pull request may close this issue.

Implementation of Module singularities JP-HellParadise/LogisticsPipes
2 participants
@bziemons @KorewaLidesu