Skip to content

fix scons --target=cmake command failure #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mypx-coder
Copy link

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

scons创建cmake报错

 scons --target=cmake
scons: Reading SConscript files ...
Newlib version: 4.1.0
E:\project\rt-thread\tools\cmake.py:151: SyntaxWarning: invalid escape sequence '\s'
  cm_file.write("SET(CMAKE_EXE_LINKER_FLAGS \""+ re.sub(LINKER_FLAGS + '(\s*)', LINKER_FLAGS + ' ${CMAKE_SOURCE_DIR}/', LFLAGS) + LINKER_LIBS + "\")\n\n")
E:\project\rt-thread\tools\cmake.py:155: SyntaxWarning: invalid escape sequence '\w'
  pattern = re.compile('-std=[\w+]+')
Update setting files for CMakeLists.txt...
Cannot find the param of the cpp standard in build flag, set to default 17
Done!

你的解决方案是什么 (what is your solution)

使用原始字符串(Raw String)避免转义问题

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
    使用stm32h723-st-nucleo测试
  • .config:
    无需修改
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the tools label May 14, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

scons: Reading SConscript files ...
Cannot found RT-Thread root directory, please check RTT_ROOT
@supperthomas
Copy link
Member

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@supperthomas supperthomas requested a review from Copilot May 16, 2025 01:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the scons --target=cmake command failure by switching to raw string literals in regex patterns to avoid syntax warnings, and makes a minor update in the SConscript.

  • Update raw string usages in tools/cmake.py to resolve invalid escape sequences.
  • Add Import('RTT_ROOT') in bsp/stm32/stm32h723-st-nucleo/SConscript for improved configuration handling.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/cmake.py Refactored regex literals using raw strings to fix escape issue warnings.
bsp/stm32/stm32h723-st-nucleo/SConscript Added an import statement to ensure correct build environment setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: STM32 BSP related with ST/STM32 BSP tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants