Transforming string concatenations to template strings #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8.
Draft PR with hacky code that transforms any line containing
import(...)
to a template string as a preprocessing step, but without checking the original content.If the original line was not even a string concatenation, but e.g. part of a regex as happening here, it breaks the regex.
If the user is aware of this risk, the code can be used in combination with the
filter
option, as to not break other module code. But it would be nicer to be able to prevent the issue entirely:Normally, this line does a final check if the import statement contains a template string. But since the new code has transformed
destinationFile
to a template string already, the check is now useless. If this condition was changed to effectively check whether the original line was either a template string, or a valid import statement containing simple string concatenation, this code should work fine. But I did not find a robust way to check that.An alternative to using this code would be to let ESLint do the job: The prefer-template rule can be enforced via the
--fix
option, which might be a robust preprocessing step for string concatenation.