Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

35 modules in agent should be dict #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

35 modules in agent should be dict #36

wants to merge 3 commits into from

Conversation

EserSteffen
Copy link
Collaborator

No description provided.

@EserSteffen EserSteffen linked an issue Sep 20, 2024 that may be closed by this pull request
Modules in agent should be dict #35
Open
FWuellhorst
FWuellhorst approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to keep the list option on the long run, ignore my comments. Else, I would already move to full dict and add a warning

examples/communicator/mqtt.py
"id": "myID",
"modules": [
{
"module_id": "MyComID",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to dict as well?

examples/multi-agent-systems/pingpong/pingpong_local.py
Comment on lines +13 to +17
{"module_id": "Ag1Com", "type": "local", "subscriptions": ["SecondAgent"]},
{
"module_id": "Ping",
"type": {"file": pingpong_module.__file__, "class_name": "PingPong"},
"start": True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again

examples/multi-agent-systems/pingpong/pingpong_local_broadcast.py
agent_config1 = {
"id": "FirstAgent",
"modules": [
{"module_id": "Ag1Com", "type": "local_broadcast"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, check all

agentlib/core/agent.py
Comment on lines +69 to +71
if isinstance(modules, dict):
for module_id, module in modules.items():
if isinstance(module, (str, Path)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we just support both and don't do deprication warnings? If so, you can ignore my comments below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules in agent should be dict
3 participants
@EserSteffen @FWuellhorst @SteffenEserAC