Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart FmuModel on failure #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Restart FmuModel on failure #39

wants to merge 1 commit into from

Conversation

JAG-1337
Copy link
Collaborator

No description provided.

@JAG-1337 JAG-1337 linked an issue Oct 29, 2024 that may be closed by this pull request
Restart FMU-Model on failure #38
Open
@EserSteffen
Copy link
Collaborator

Hey, thanks for adding, looks good!
Can you include a test to preserve coverage?

@JAG-1337
Copy link
Collaborator Author

Hey, thanks for adding, looks good! Can you include a test to preserve coverage?

By adding a failing FMU?

@EserSteffen
Copy link
Collaborator

Hey, thanks for adding, looks good! Can you include a test to preserve coverage?

By adding a failing FMU?

Good question. Maybe monkey-patch the system.do_step to raise the error?

@JAG-1337
Copy link
Collaborator Author

There's the test_sinus.fmu used in test_model.py. This can probably be extended with an additional input u_div which enters in the denominator of a division to trigger an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EserSteffen EserSteffen Awaiting requested review from EserSteffen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart FMU-Model on failure
2 participants
@JAG-1337 @EserSteffen