-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to new HP models #84
Conversation
Thank you for making a Pull Request to BESMod! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
…nto 83_newHPmodels
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
When using this branch the HP only starts below the bivalent point. When using BESMod.Systems.Hydraulical.Control.MonoenergeticHeatPumpSystem as control and BESMod.Systems.Hydraulical.Generation.HeatPumpAndElectricHeater as generation the safety control of the heat pump prevents it from starting up if there is not a minimum flow through the condenser. However the condenser side pump only spins up if at least one heat generation device (hp/electric) is running. Essentially safety control and the control for the pump lock itself until the outdoor temperature falls below the bivalent point and the electric heater starts up, allowing the pump to spin. |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
…nto 83_newHPmodels
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI passes, the changes work for myself and @Mov0. Going to merge now.
Closes #83