Fix concurrency issues in tests to make build stable. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrypacker
commented
Feb 13, 2025
| @@ -175,8 +176,10 @@ public boolean isLogDisabled() { | |||
| return logDisabled; | |||
| } | |||
|
|
|||
| public LogBuffer<LogMultipleRecord> getBuffer() { | |||
| return buffer; | |||
| public void withBuffer(Consumer<LogBuffer<LogMultipleRecord>> bufferConsumer) { | |||
There was a problem hiding this comment.
This is one of the 2 changes that make the tests pass, accessing the buffer in a thread safe manner.
terrypacker
commented
Feb 13, 2025
| @@ -204,8 +205,10 @@ public boolean isLogDisabled() { | |||
| return logDisabled; | |||
| } | |||
|
|
|||
| public LogBuffer<LogRecord> getBuffer() { | |||
| return buffer; | |||
| public void withBuffer(Consumer<LogBuffer<LogRecord>> bufferConsumer) { | |||
There was a problem hiding this comment.
This is one of the 2 changes that make the tests pass, accessing the buffer in a thread safe manner.
As per MANGO-1975
As per MANGO-1975
As per MANGO-1975
terrypacker
requested review from
jazdw and
a team
and removed request for
a team
jazdw
approved these changes
Mar 3, 2025
Requires sero-warp 1.0.1-SNAPSHOT (Not released) As per MANGO-1975
As per MANGO-1975
As per MANGO-1975
…ice. As per MANGO-1975
As per MANGO-1975
As per MANGO-1981
…e them in tests As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
Fix DeviceCommunicationControlRequestTest As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
…and refactor for sonarqube As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
As per MANGO-1981 In preparation for MANGO-2061
This is possible as we are creating a "Larger Work" of combined MPL + GNU licensed code
…sport As per MANGO-2104
* Remove unused wildcard methods * Remove unnecessary static modifier
Changes for schedule object test to be reliable.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding and fixing many timing related issues for testing.
Adding an abstraction for the Network and Transport layers to use in testing for better reproducibility.
Kown tests that still need to be fixed due to sporadic failing:
Tickets handled here:
Ticket not handled here: