Fix some portability issues #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`char`s are not necessarily signed and on some architectures that means that `CHAR_MAX` is 255. This causes gcc to complain about array bound mismatch because it's hardcoded as 127 in declaration.
`fgetc` returns `int` and `EOF` does not necessarily fit into `char` which may cause infinite loops or premature finish of reading.
`vs_mainVisual` is initialized to -1 and `au_mainPlay` calls `vs_mainStop` before `vs_mainPlay` causing out of bounds write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into some bugs while trying to run this game on
aarch64-linux. Motivations for all changes are in commit descriptions.