Move sync_generator logic into classes #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eelcoj
commented
Dec 14, 2024
lib/rails_icons/sync/engine.rb
Outdated
|
|
||
| move_library | ||
|
|
||
| clean_temp_directory |
There was a problem hiding this comment.
purge_temp_directory is probably a better name
eelcoj
commented
Dec 14, 2024
lib/rails_icons/sync/engine.rb
Outdated
|
|
||
| def remove_non_svg_files | ||
| Pathname.glob("#{@temp_directory}/**/*") | ||
| .select { |p| p.file? && p.extname != ".svg" } |
There was a problem hiding this comment.
.select { _1.file? && _1.extname != ".svg" } ?
eelcoj
commented
Dec 14, 2024
lib/rails_icons/sync/engine.rb
Outdated
| end | ||
|
|
||
| def clean_temp_directory | ||
| FileUtils.rm_rf(TEMP_DIRECTORY) if Dir.exist?(TEMP_DIRECTORY) |
There was a problem hiding this comment.
Unneeded if-check rm_rf does not raise an error if the directory doesn't exist. While at it: this probably doesn't need to be in a separate method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to keep things tidier: