-
Notifications
You must be signed in to change notification settings - Fork 290
Modules rewrite #4570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modules rewrite #4570
Conversation
… On the downside, the output is uglier. On the upside, it doesn't hang.
I guess my main point is that it's better than it was before :) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a curl option to hide the output instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAKULIB should be . (current directory's META6.json), not lib
This seems to be a good start. I absolutely agree the modules part needed restructuring. From the site building point of view, it does not matter which directory the files are placed, so long as the meta date at the top of the file (in the line with Richard |
|
@wayland Ok understood that the main work currently is about regrouping, and that's definitely important. I do mean a page on documenting a module. I agree more needs writing - its a TODO of mine. |
Hi! I've made the following updates:
HTH, |
it represents, such as a file, for instance | ||
|
||
=for code | ||
my @data = %?RESOURCES<data/swim.csv>.lines.split(","); | ||
|
||
However, this is I<not> because it returns an L<C<IO::Path>|/type/IO::Path>, but because it | ||
shares many method with it: C<Str, gist, raku, absolute, is-absolute, | ||
However, this was found to be problematic due to the fact that the path can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it makes sense to talk about what why things are implemented the way they are in the docs e.g. "was found to be problematic". Someone looking at the docs presumably wants to know how to use something and not necessarily the history or implementation details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've rewritten this section so that it:
- Keeps most of the old material (but updates the deprecation list
- Adds a paragraph on what not to do (which was what I was trying to achieve), but without listing the deprecated methods
Would very much appreciate your feedback, since I seem to get this wrong on the regular.
Thanks!
get compiled into the library at compile time, which means that it can end | ||
up pointing to the wrong place at runtime. Thus, many of the methods that | ||
were shared with L<C<IO::Path>|/type/IO::Path> are now deprecated; this | ||
includes C<Str, gist, raku, absolute, is-absolute, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Str
or gist
is giving a deprecation message then that is a bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at https://github.com/rakudo/rakudo/blob/b527cefcb29789120f32d5e4003913e53c47476f/src/core.c/Distribution/Resource.rakumod#L50 when compiling this list; was that incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant .raku or .gist aren’t deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Right. Well, I've completely left them out this time around because
- I wasn't sure of their status
- They're not specific to mirroring IO::Path, they're on just about everything, so I figured they didn't need a mention.
HTH,
relative, is-relative, parts, volume, dirname, basename, extension, open, | ||
resolve, slurp, lines, comb, split, words, copy>; above we use C<.lines>, for | ||
instance. | ||
resolve, slurp, lines, comb, split, words, copy>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is not accurate. You can see the deprecations explicitly defined in the source. Notably slurp, lines, and other methods that don't return a string representation of a path or path part.
I also think listing all the deprecated methods is rather distracting, and that listing the methods that are actually allowed (similar to the original description) makes the most sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll be rewriting this section in line with your recommendations.
Just my notes on the old version of the list as to what's still current and what isn't. I'm mainly posting it here for feedback on .gist and .raku (given that .Str is deprecated).
- Deprecated: Str, absolute, is-absolute, resolve
- Not sure: gist, raku
- Still good: slurp, lines, comb, split, words, copy
Also regularised use of subkind across the new pages (to "Modules"). |
The problem
The module/package documentation was suboptimally organised, as per #3714
Solution provided
Organised documentation less suboptimally.
Things to note:
I'm expecting feedback on things I need to change.
Hope this helps.