Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "drenv setup" documented step as it lead to an misleading error #1604

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

pruthvitd
Copy link
Contributor

@pruthvitd pruthvitd commented Oct 25, 2024

Updated documentation step "drenv setup" as it lead to following error:

$ drenv setup
usage: drenv setup [-h] [-v] [--name-prefix PREFIX] filename
drenv setup: error: the following arguments are required: filename

test/README.md Show resolved Hide resolved
test/README.md Show resolved Hide resolved
@nirs
Copy link
Member

nirs commented Nov 4, 2024

@pruthvitd do you plan to update this?

@pruthvitd
Copy link
Contributor Author

@pruthvitd do you plan to update this?

Hi @nirs Could you please review, the changes suggested have been incorporated.

@nirs
Copy link
Member

nirs commented Nov 7, 2024

Removed documentation step "drenv setup" as its unnecessary and leads to following error:

$ drenv setup usage: drenv setup [-h] [-v] [--name-prefix PREFIX] filename drenv setup: error: the following arguments are required: filename

Need to update to reflect the actual change.

Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits, we want clean git history with one commit per logical change.

test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
@pruthvitd pruthvitd requested a review from nirs November 12, 2024 10:22
@pruthvitd pruthvitd changed the title Removed drenv setup Updated "drenv setup" as error was misleading Nov 12, 2024
@pruthvitd pruthvitd changed the title Updated "drenv setup" as error was misleading Updated "drenv setup" documented step as it lead to an misleading error Nov 12, 2024
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Show resolved Hide resolved
Updated documentation step "drenv setup" as it lead to following error:

    $ drenv setup
    usage: drenv setup [-h] [-v] [--name-prefix PREFIX] filename
    drenv setup: error: the following arguments are required: filename

Signed-off-by: pruthvitd <[email protected]>
Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nirs nirs merged commit cdd63a9 into RamenDR:main Nov 12, 2024
18 checks passed
@pruthvitd pruthvitd deleted the readme-changes branch November 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants