Skip to content

Conversation

@jsheffers
Copy link

Implemented fix recommended here by @Rapsssito

@Rapsssito
Copy link
Owner

Rapsssito commented Dec 26, 2025

Hi @jsheffers,

Thanks for the PR. However, this would mean something has gone terribly wrong. Since the onConnect callback should not be called with those properties being nil. This would just hang the JS forever waiting for a callback that won't be called.

See https://github.com/Rapsssito/react-native-tcp-socket/pull/172/changes#r2057757792

The correct approach is to find out why those properties are nil when the callback is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants