Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP | DRAFT | DO-NOT-MERGE] ENG-1235: change credentials of release tagger #1144

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −16
Draft

[WIP | DRAFT | DO-NOT-MERGE] ENG-1235: change credentials of release tagger #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
562d7f1
ENG-1235: change credentials of release tagger
AsadHasan-Rasa Sep 12, 2024
5ba0c6e
ENG-1235: Testing the change in GHA WF, so temporarily disabling bran…
AsadHasan-Rasa Sep 12, 2024
580bd70
ENG-1235: disabling another check
AsadHasan-Rasa Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tag-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ on:
branches:
- main
- '[0-9]+.[0-9]+.x'
types: [closed]
# types: [closed]
workflow_dispatch:

env:
COMMIT_EMAIL: [email protected].com
COMMIT_EMAIL: rasabot@rasa.com
DEFAULT_PYTHON_VERSION: "3.10"

jobs:
if_merged_tag_release:
name: Tag Release Version
if: startsWith(github.head_ref, 'prepare-release-') && github.event.pull_request.merged == true
## if: startsWith(github.head_ref, 'prepare-release-') && github.event.pull_request.merged == true
runs-on: ubuntu-22.04
steps:
- name: Checkout git repository 🕝
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Configure git
run: |
git config --global user.email ${{ env.COMMIT_EMAIL }}
git config --global user.name "Github Actions"
git config --global user.name "rasabot"

- name: Tag Release
run: make tag-release
24 changes: 12 additions & 12 deletions scripts/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,18 +327,18 @@ def tag_release() -> None:
branch = git_current_branch()
version = Version(get_current_version())

if (
not version.is_alpha
and not version.is_beta
and not git_current_branch_is_main_or_release()
):
print(
f"""
You are currently on branch {branch}.
You should only apply release tags to release branches (e.g. 1.x) or main.
"""
)
sys.exit(1)
# if (
# not version.is_alpha
# and not version.is_beta
# and not git_current_branch_is_main_or_release()
# ):
# print(
# f"""
# You are currently on branch {branch}.
# You should only apply release tags to release branches (e.g. 1.x) or main.
# """
# )
# sys.exit(1)
ensure_clean_git()
tag = str(version)
tag_commit(tag)
Expand Down
Loading