feat: Improve trust plugin dialog design #2420
Conversation
Ushie
added
the
ReVanced Manager Compose
app/src/main/java/app/revanced/manager/ui/screen/settings/DownloadsSettingsScreen.kt
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Offtopic, but why does it say "ReVanced Manager: ..."? |
|
I think the importance of this screen and dialog is enabling and disabling plugins. Trusting them is a secondary task to achieve that main objective. Strings can be renamed to say "Enable" or "Disable" plugin. And the dialog can mention that enabling the plugin can run arbitrary code and need to be trusted as a "side notice" |
| @@ -137,7 +137,10 @@ | |||
| <string name="downloader_plugin_state_untrusted">Untrusted</string> | |||
| <string name="downloader_plugin_trust_dialog_title">Trust plugin?</string> | |||
| <string name="downloader_plugin_revoke_trust_dialog_title">Revoke trust?</string> | |||
| <string name="downloader_plugin_trust_dialog_body">Package name: %1$s\nSignature (SHA-256): %2$s</string> | |||
| <string name="downloader_plugin_trust_dialog_body">By continuing you\'ve agreed to running external plugins.\n\nDo not allow any suspicious plugin(s) to be installed as they can run arbitrary code.</string> | |||
There was a problem hiding this comment.
Sounds like youre signing some legal document. Probably different wording would be better here.
Placeholder representation of the app name |
|
I am not sure what you mean by placeholder. What would be written there if others develop plugins? |
|
The app name of the plugin — for example, the APKMirror plugin would be named ReVanced Manager: APKMirror. This accurately represents what the app is and its purpose. If it were just APKMirror, you wouldn't know it is for ReVanced Manager in the app list, and that it isn't actually by APKMirror. |
|
It should probably say "ReVanced: APKMirror downloader" or "Ushie: Some other downloader" |
|
Would Ushie make sense here? It serves no purpose knowing who the developer is, knowing what app it's for is what makes more sense |
app/src/main/java/app/revanced/manager/ui/screen/settings/DownloadsSettingsScreen.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
force-pushed
the
compose-dev
branch
3 times, most recently
from
7338157 to
70a6950
Compare
brosssh
force-pushed
the
compose/feat/improve-trust-plugin-dialog
branch
from
ba1271b to
47129cd
Compare
Closes #2061