Skip to content

fix: Patch selection screen padding #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: compose-dev
Choose a base branch
from

Conversation

brosssh
Copy link
Member

@brosssh brosssh commented May 8, 2025

Closes #2520 and also #2502

Enough? Too much?
Screenshot_2025-05-08-10-25-45-49_761fe8f2c59677c7476dd46708cfb34f

image0

@oSumAtrIX oSumAtrIX requested a review from Axelen123 May 8, 2025 08:51
@validcube validcube added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label May 8, 2025
Copy link
Member

@Axelen123 Axelen123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. @validcube or @Ushie can answer your question regarding the padding.

@Axelen123 Axelen123 requested review from Ushie and validcube May 8, 2025 16:36
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞 Padding looks good to me.

@Ushie Ushie marked this pull request as draft May 8, 2025 19:56
@Ushie
Copy link
Member

Ushie commented May 9, 2025

Can the padding be made more consistent with other screens?

I believe I use verticalArrangement for Columns across the app, that can be used for the dialog padding

As for the patches page padding, I don't exactly remember what it's called but I don't think I outright add padding, I think it might be called innerPadding in lazycolumns or something, also, why is there a lack of padding to begin with? there's supposed to be a default amount of padding, that should be looked into

@Ushie Ushie changed the title Fix(Compose): Add padding in patch selection screen fix: Patch selection screen padding May 20, 2025
@oSumAtrIX oSumAtrIX force-pushed the compose-dev branch 3 times, most recently from 7338157 to 70a6950 Compare May 22, 2025 12:16
@brosssh brosssh force-pushed the fix/compose/padding-patch-selector branch from 4e6be72 to e3a501b Compare June 2, 2025 16:07
@brosssh
Copy link
Member Author

brosssh commented Jun 3, 2025

@Ushie
I checked but verticalArrangement is not adding the padding. I believe that is used to space items in a Column component, while I need to add it to the top of the component..

@Ushie
Copy link
Member

Ushie commented Jun 3, 2025

The verticalArrangement thing is for the add bundle dialog

contentPadding is for the patches screen, I'm not sure if contentPadding will work for landscape but it's worth a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Padding missing between search and patches list bug: Missing padding in add patches via URL dialog
4 participants