-
-
Notifications
You must be signed in to change notification settings - Fork 842
fix: Patch selection screen padding #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: compose-dev
Are you sure you want to change the base?
fix: Patch selection screen padding #2533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. @validcube or @Ushie can answer your question regarding the padding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥞 Padding looks good to me.
Can the padding be made more consistent with other screens? I believe I use verticalArrangement for Columns across the app, that can be used for the dialog padding As for the patches page padding, I don't exactly remember what it's called but I don't think I outright add padding, I think it might be called innerPadding in lazycolumns or something, also, why is there a lack of padding to begin with? there's supposed to be a default amount of padding, that should be looked into |
7338157
to
70a6950
Compare
4e6be72
to
e3a501b
Compare
@Ushie |
The verticalArrangement thing is for the add bundle dialog contentPadding is for the patches screen, I'm not sure if contentPadding will work for landscape but it's worth a try |
Closes #2520 and also #2502
Enough? Too much?
