Skip to content

feat: Set app ownership when installing apps #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: compose-dev
Choose a base branch
from

Conversation

brosssh
Copy link
Member

@brosssh brosssh commented May 20, 2025

Implemented #2556 in compose

@Ushie Ushie added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label May 20, 2025
@brosssh
Copy link
Member Author

brosssh commented May 20, 2025

Result is like this:
Screenshot_2025-05-20-17-20-42-98_b5a5c5cb02ca09c784c5d88160e2ec24.jpg

(Apologize for the Italian, it's saying "the app installed does not come from Play Store, you can update from the app source of reinstall from Play Store)

@oSumAtrIX
Copy link
Member

ReVanced Library is supposed to host installation code. This way ReVanced CLI can also benefit of this change. ReVanced Library installer isn't used yet in Manager so that can be looked into in this PR

@Ushie Ushie changed the title feat(Compose): Set ownership on installed app feat: Set app ownership when installing apps May 20, 2025
@brosssh
Copy link
Member Author

brosssh commented May 20, 2025

ReVanced Library is supposed to host installation code. This way ReVanced CLI can also benefit of this change. ReVanced Library installer isn't used yet in Manager so that can be looked into in this PR

I'm not sure I understand, setRequestUpdateOwnership is part of the Android API, there is no equivalent that can be used by the CLI as far as I know.

@oSumAtrIX
Copy link
Member

CLI used ADB and via ADB pm is used which should offer this API

@brosssh
Copy link
Member Author

brosssh commented May 21, 2025

I cannot find anything similar for ADB/ABD pm, feel free to share if you find anything that can do this job.

@oSumAtrIX
Copy link
Member

pm lists --update-ownership: request the update ownership enforcement

@Axelen123
Copy link
Member

This needs to be rebased

@Ushie
Copy link
Member

Ushie commented May 25, 2025

What happened to the repository that changed the history this much?

@validcube
Copy link
Member

validcube commented May 25, 2025 via email

@Ushie
Copy link
Member

Ushie commented May 25, 2025

The rebase shouldn't have been done with pending PRs that are meant to be merged before release

@oSumAtrIX
Copy link
Member

As explained on discord you merely need to cherry pick your commits onto the target branch, no conflicts. We can't wait for all PRs

@brosssh brosssh force-pushed the feat/compose/obtain-app-ownership branch from 7182de3 to 322d240 Compare May 26, 2025 06:18
@brosssh
Copy link
Member Author

brosssh commented May 30, 2025

ReVanced Library installer isn't used yet in Manager so that can be looked into in this PR

At this point of time, compose manager partially supports bundle patching by patching the base.apk. This works only for Bytecode patches. The library does not handle bundles (yet), so if ReVanced Library needs to be used in this project, bundle support need to be dropped in the current compose. This requires a bit of work.

image

Can't this small change be applied now and address bundle support/drop in another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants